Title: [248218] releases/WebKitGTK/webkit-2.24
Revision
248218
Author
[email protected]
Date
2019-08-03 20:22:34 -0700 (Sat, 03 Aug 2019)

Log Message

Merge r244996 - [JSC] We should check OOM for description string of Symbol
https://bugs.webkit.org/show_bug.cgi?id=197634

Reviewed by Keith Miller.

JSTests:

* stress/check-symbol-description-oom.js: Added.
(shouldThrow):

Source/_javascript_Core:

When resoling JSString for description of Symbol, we should check OOM error.
We also change JSValueMakeSymbol(..., nullptr) to returning a symbol value
without description, (1) to simplify the code and (2) give a way for JSC API
to create a symbol value without description.

* API/JSValueRef.cpp:
(JSValueMakeSymbol):
* API/tests/testapi.cpp:
(TestAPI::symbolsTypeof):
(TestAPI::symbolsDescription):
(testCAPIViaCpp):
* dfg/DFGOperations.cpp:
* runtime/Symbol.cpp:
(JSC::Symbol::createWithDescription):
* runtime/Symbol.h:
* runtime/SymbolConstructor.cpp:
(JSC::callSymbol):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog (248217 => 248218)


--- releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog	2019-08-04 03:22:33 UTC (rev 248217)
+++ releases/WebKitGTK/webkit-2.24/JSTests/ChangeLog	2019-08-04 03:22:34 UTC (rev 248218)
@@ -1,3 +1,13 @@
+2019-05-06  Yusuke Suzuki  <[email protected]>
+
+        [JSC] We should check OOM for description string of Symbol
+        https://bugs.webkit.org/show_bug.cgi?id=197634
+
+        Reviewed by Keith Miller.
+
+        * stress/check-symbol-description-oom.js: Added.
+        (shouldThrow):
+
 2019-05-04  Tadeu Zagallo  <[email protected]>
 
         TypedArrays should not store properties that are canonical numeric indices

Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog (248217 => 248218)


--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog	2019-08-04 03:22:33 UTC (rev 248217)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog	2019-08-04 03:22:34 UTC (rev 248218)
@@ -1,3 +1,28 @@
+2019-05-06  Yusuke Suzuki  <[email protected]>
+
+        [JSC] We should check OOM for description string of Symbol
+        https://bugs.webkit.org/show_bug.cgi?id=197634
+
+        Reviewed by Keith Miller.
+
+        When resoling JSString for description of Symbol, we should check OOM error.
+        We also change JSValueMakeSymbol(..., nullptr) to returning a symbol value
+        without description, (1) to simplify the code and (2) give a way for JSC API
+        to create a symbol value without description.
+
+        * API/JSValueRef.cpp:
+        (JSValueMakeSymbol):
+        * API/tests/testapi.cpp:
+        (TestAPI::symbolsTypeof):
+        (TestAPI::symbolsDescription):
+        (testCAPIViaCpp):
+        * dfg/DFGOperations.cpp:
+        * runtime/Symbol.cpp:
+        (JSC::Symbol::createWithDescription):
+        * runtime/Symbol.h:
+        * runtime/SymbolConstructor.cpp:
+        (JSC::callSymbol):
+
 2019-05-04  Tadeu Zagallo  <[email protected]>
 
         TypedArrays should not store properties that are canonical numeric indices
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to