Title: [248251] releases/WebKitGTK/webkit-2.24/Source/WebCore
Revision
248251
Author
[email protected]
Date
2019-08-03 20:24:00 -0700 (Sat, 03 Aug 2019)

Log Message

Merge r247427 - [GTK] GitHub breaks on FreeBSD because of "unsupported browser"
https://bugs.webkit.org/show_bug.cgi?id=199745

Reviewed by Carlos Garcia Campos.

It's been a while since I last updated the fake version numbers in our user agent, both for
the user agent quirks for naughty websites and also the Safari version in our standard user
agent. Update them. This should fix github.com on FreeBSD at least. I also noticed some
wonkiness on Google Docs recently that I thought required this update, but I didn't do
anything about it at the time because I wasn't able to reproduce the issue when I tried
again later.

This could absolutely break websites, because the web is awful, but that's calculated risk.

* platform/UserAgentQuirks.cpp:
(WebCore::UserAgentQuirks::stringForQuirk):
* platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (248250 => 248251)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-08-04 03:23:58 UTC (rev 248250)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog	2019-08-04 03:24:00 UTC (rev 248251)
@@ -1,3 +1,24 @@
+2019-07-15  Michael Catanzaro  <[email protected]>
+
+        [GTK] GitHub breaks on FreeBSD because of "unsupported browser"
+        https://bugs.webkit.org/show_bug.cgi?id=199745
+
+        Reviewed by Carlos Garcia Campos.
+
+        It's been a while since I last updated the fake version numbers in our user agent, both for
+        the user agent quirks for naughty websites and also the Safari version in our standard user
+        agent. Update them. This should fix github.com on FreeBSD at least. I also noticed some
+        wonkiness on Google Docs recently that I thought required this update, but I didn't do
+        anything about it at the time because I wasn't able to reproduce the issue when I tried
+        again later.
+
+        This could absolutely break websites, because the web is awful, but that's calculated risk.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::UserAgentQuirks::stringForQuirk):
+        * platform/glib/UserAgentGLib.cpp:
+        (WebCore::buildUserAgentString):
+
 2019-07-10  Enrique Ocaña González  <[email protected]>
 
         [GStreamer] Protect against null samples and samples with null buffers

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/UserAgentQuirks.cpp (248250 => 248251)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/UserAgentQuirks.cpp	2019-08-04 03:23:58 UTC (rev 248250)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/UserAgentQuirks.cpp	2019-08-04 03:24:00 UTC (rev 248251)
@@ -138,9 +138,9 @@
     switch (quirk) {
     case NeedsChromeBrowser:
         // Get versions from https://chromium.googlesource.com/chromium/src.git
-        return "Chrome/58.0.3029.81"_s;
+        return "Chrome/75.0.3770.141"_s;
     case NeedsMacintoshPlatform:
-        return "Macintosh; Intel Mac OS X 10_13_4"_s;
+        return "Macintosh; Intel Mac OS X 10_15"_s;
     case NeedsLinuxDesktopPlatform:
         return "X11; Linux x86_64"_s;
     case NumUserAgentQuirks:

Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/glib/UserAgentGLib.cpp (248250 => 248251)


--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/glib/UserAgentGLib.cpp	2019-08-04 03:23:58 UTC (rev 248250)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/glib/UserAgentGLib.cpp	2019-08-04 03:24:00 UTC (rev 248251)
@@ -103,7 +103,7 @@
 
     // Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
     // https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
-    uaString.appendLiteral("Version/11.0 Safari/");
+    uaString.appendLiteral("Version/13.0 Safari/");
     uaString.append(versionForUAString());
 
     return uaString.toString();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to