Title: [248278] trunk/Source/WebCore
- Revision
- 248278
- Author
- [email protected]
- Date
- 2019-08-05 16:25:45 -0700 (Mon, 05 Aug 2019)
Log Message
RealtimeOutgoingAudioSource::pullAudioData is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=200450
Reviewed by Geoffrey Garen.
No change of behavior, removing base class method declaration.
* platform/mediastream/RealtimeOutgoingAudioSource.h:
(WebCore::RealtimeOutgoingAudioSource::pullAudioData): Deleted.
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248277 => 248278)
--- trunk/Source/WebCore/ChangeLog 2019-08-05 23:17:48 UTC (rev 248277)
+++ trunk/Source/WebCore/ChangeLog 2019-08-05 23:25:45 UTC (rev 248278)
@@ -1,3 +1,17 @@
+2019-08-05 Youenn Fablet <[email protected]>
+
+ RealtimeOutgoingAudioSource::pullAudioData is no longer needed
+ https://bugs.webkit.org/show_bug.cgi?id=200450
+
+ Reviewed by Geoffrey Garen.
+
+ No change of behavior, removing base class method declaration.
+
+ * platform/mediastream/RealtimeOutgoingAudioSource.h:
+ (WebCore::RealtimeOutgoingAudioSource::pullAudioData): Deleted.
+ * platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:
+ * platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
+
2019-08-05 Saam Barati <[email protected]>
[WHLSL] Add compile time flag to dump metal compile times
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h (248277 => 248278)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2019-08-05 23:17:48 UTC (rev 248277)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2019-08-05 23:25:45 UTC (rev 248278)
@@ -74,8 +74,6 @@
void unobserveSource();
- virtual void pullAudioData() { }
-
bool isSilenced() const { return m_muted || !m_enabled; }
void sendAudioFrames(const void* audioData, int bitsPerSample, int sampleRate, size_t numberOfChannels, size_t numberOfFrames);
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h (248277 => 248278)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h 2019-08-05 23:17:48 UTC (rev 248277)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h 2019-08-05 23:25:45 UTC (rev 248278)
@@ -46,7 +46,7 @@
bool isReachingBufferedAudioDataLowLimit() final;
bool hasBufferedEnoughData() final;
- void pullAudioData() final;
+ void pullAudioData();
GUniquePtr<GstAudioConverter> m_sampleConverter;
std::unique_ptr<GStreamerAudioStreamDescription> m_inputStreamDescription;
Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h (248277 => 248278)
--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h 2019-08-05 23:17:48 UTC (rev 248277)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h 2019-08-05 23:25:45 UTC (rev 248278)
@@ -52,7 +52,7 @@
bool hasBufferedEnoughData() final;
void sourceUpdated() final;
- void pullAudioData() final;
+ void pullAudioData();
Ref<AudioSampleDataSource> m_sampleConverter;
CAAudioStreamDescription m_inputStreamDescription;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
