Title: [248295] trunk/Source/WebCore
Revision
248295
Author
an...@apple.com
Date
2019-08-06 08:37:28 -0700 (Tue, 06 Aug 2019)

Log Message

REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
https://bugs.webkit.org/show_bug.cgi?id=200466

Reviewed by Zalan Bujtas.

The page calls preventDefault() for a mouse event generated by a site specific quirk.

* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (248294 => 248295)


--- trunk/Source/WebCore/ChangeLog	2019-08-06 15:01:53 UTC (rev 248294)
+++ trunk/Source/WebCore/ChangeLog	2019-08-06 15:37:28 UTC (rev 248295)
@@ -1,3 +1,17 @@
+2019-08-06  Antti Koivisto  <an...@apple.com>
+
+        REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=200466
+
+        Reviewed by Zalan Bujtas.
+
+        The page calls preventDefault() for a mouse event generated by a site specific quirk.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
+        Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.
+
 2019-08-06  Wenson Hsieh  <wenson_hs...@apple.com>
 
         [iPadOS] Unable to increase zoom level on Google using the Aa menu

Modified: trunk/Source/WebCore/page/Quirks.cpp (248294 => 248295)


--- trunk/Source/WebCore/page/Quirks.cpp	2019-08-06 15:01:53 UTC (rev 248294)
+++ trunk/Source/WebCore/page/Quirks.cpp	2019-08-06 15:37:28 UTC (rev 248295)
@@ -295,9 +295,16 @@
         return true;
     if (equalLettersIgnoringASCIICase(host, "naver.com"))
         return true;
-    // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
-    if (host.endsWithIgnoringASCIICase(".naver.com"))
-        return !equalLettersIgnoringASCIICase(host, "tv.naver.com");
+    if (host.endsWithIgnoringASCIICase(".naver.com")) {
+        // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
+        if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
+            return false;
+        // Disable the quirk on the mobile site.
+        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
+        if (equalLettersIgnoringASCIICase(host, "m.naver.com"))
+            return false;
+        return true;
+    }
     return false;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to