Title: [248325] trunk/Tools
- Revision
- 248325
- Author
- [email protected]
- Date
- 2019-08-06 16:20:43 -0700 (Tue, 06 Aug 2019)
Log Message
Unreviewed, a build fix after r248308
Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (248324 => 248325)
--- trunk/Tools/ChangeLog 2019-08-06 22:40:16 UTC (rev 248324)
+++ trunk/Tools/ChangeLog 2019-08-06 23:20:43 UTC (rev 248325)
@@ -1,5 +1,13 @@
2019-08-06 Jiewen Tan <[email protected]>
+ Unreviewed, a build fix after r248308
+
+ Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
+
+ * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
+
+2019-08-06 Jiewen Tan <[email protected]>
+
Unreviewed, a build fix after r248319
Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
Modified: trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig (248324 => 248325)
--- trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig 2019-08-06 22:40:16 UTC (rev 248324)
+++ trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig 2019-08-06 23:20:43 UTC (rev 248325)
@@ -37,5 +37,7 @@
CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = Configurations/WebKitTestRunner.entitlements;
-CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
+CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(CONFIGURATION));
+CODE_SIGN_IDENTITY_Debug = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
+CODE_SIGN_IDENTITY_Release = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
CODE_SIGN_IDENTITY_YES = $(WK_ENGINEERING_CODE_SIGN_IDENTITY);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes