Title: [248357] branches/safari-608.1-branch/Source/WebKit
Revision
248357
Author
[email protected]
Date
2019-08-06 23:52:57 -0700 (Tue, 06 Aug 2019)

Log Message

Cherry-pick r248085. rdar://problem/54017902

    WKImagePreviewViewController not being autoreleased
    https://bugs.webkit.org/show_bug.cgi?id=200325
    <rdar://problem/53788214>

    Reviewed by Wenson Hsieh.

    Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.

    * UIProcess/ios/WKContentViewInteraction.mm:
    (-[WKContentView continueContextMenuInteraction:]):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-608.1-branch/Source/WebKit/ChangeLog (248356 => 248357)


--- branches/safari-608.1-branch/Source/WebKit/ChangeLog	2019-08-07 06:52:55 UTC (rev 248356)
+++ branches/safari-608.1-branch/Source/WebKit/ChangeLog	2019-08-07 06:52:57 UTC (rev 248357)
@@ -1,5 +1,35 @@
 2019-08-06  Kocsen Chung  <[email protected]>
 
+        Cherry-pick r248085. rdar://problem/54017902
+
+    WKImagePreviewViewController not being autoreleased
+    https://bugs.webkit.org/show_bug.cgi?id=200325
+    <rdar://problem/53788214>
+    
+    Reviewed by Wenson Hsieh.
+    
+    Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
+    
+    * UIProcess/ios/WKContentViewInteraction.mm:
+    (-[WKContentView continueContextMenuInteraction:]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-07-31  Dean Jackson  <[email protected]>
+
+            WKImagePreviewViewController not being autoreleased
+            https://bugs.webkit.org/show_bug.cgi?id=200325
+            <rdar://problem/53788214>
+
+            Reviewed by Wenson Hsieh.
+
+            Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
+
+            * UIProcess/ios/WKContentViewInteraction.mm:
+            (-[WKContentView continueContextMenuInteraction:]):
+
+2019-08-06  Kocsen Chung  <[email protected]>
+
         Cherry-pick r248015. rdar://problem/54017889
 
     Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)

Modified: branches/safari-608.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (248356 => 248357)


--- branches/safari-608.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-08-07 06:52:55 UTC (rev 248356)
+++ branches/safari-608.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-08-07 06:52:57 UTC (rev 248357)
@@ -7975,7 +7975,7 @@
                 if (!strongSelf)
                     return nil;
 
-                return [[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()];
+                return [[[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()] autorelease];
             };
 
             return continueWithContextMenuConfiguration([UIContextMenuConfiguration configurationWithIdentifier:nil previewProvider:contentPreviewProvider actionProvider:actionMenuProvider]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to