Title: [248370] trunk/Source/WebCore
- Revision
- 248370
- Author
- wenson_hs...@apple.com
- Date
- 2019-08-07 10:17:05 -0700 (Wed, 07 Aug 2019)
Log Message
Declarations and implementations of findCaret(Min|Max)imumOffset have inconsistent signatures
https://bugs.webkit.org/show_bug.cgi?id=200503
Reviewed by Darin Adler.
No change in behavior.
* rendering/SimpleLineLayoutFunctions.h:
Update these function declarations to take "const RenderText&", which matches the signatures of their inline
implementations below.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248369 => 248370)
--- trunk/Source/WebCore/ChangeLog 2019-08-07 16:41:33 UTC (rev 248369)
+++ trunk/Source/WebCore/ChangeLog 2019-08-07 17:17:05 UTC (rev 248370)
@@ -1,5 +1,19 @@
2019-08-07 Wenson Hsieh <wenson_hs...@apple.com>
+ Declarations and implementations of findCaret(Min|Max)imumOffset have inconsistent signatures
+ https://bugs.webkit.org/show_bug.cgi?id=200503
+
+ Reviewed by Darin Adler.
+
+ No change in behavior.
+
+ * rendering/SimpleLineLayoutFunctions.h:
+
+ Update these function declarations to take "const RenderText&", which matches the signatures of their inline
+ implementations below.
+
+2019-08-07 Wenson Hsieh <wenson_hs...@apple.com>
+
Extra space inserted at start of line when inserting a newline in Mail compose
https://bugs.webkit.org/show_bug.cgi?id=200490
<rdar://problem/53501354>
Modified: trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.h (248369 => 248370)
--- trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.h 2019-08-07 16:41:33 UTC (rev 248369)
+++ trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.h 2019-08-07 17:17:05 UTC (rev 248370)
@@ -52,8 +52,8 @@
bool isTextRendered(const RenderText&, const Layout&);
enum class OffsetType { CaretOffset, CharacterOffset };
bool containsOffset(const RenderText&, const Layout&, unsigned, OffsetType);
-unsigned findCaretMinimumOffset(const RenderObject&, const Layout&);
-unsigned findCaretMaximumOffset(const RenderObject&, const Layout&);
+unsigned findCaretMinimumOffset(const RenderText&, const Layout&);
+unsigned findCaretMaximumOffset(const RenderText&, const Layout&);
IntRect computeBoundingBox(const RenderObject&, const Layout&);
IntPoint computeFirstRunLocation(const RenderObject&, const Layout&);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
