Title: [248392] trunk/LayoutTests
Revision
248392
Author
[email protected]
Date
2019-08-07 14:51:16 -0700 (Wed, 07 Aug 2019)

Log Message

LayoutTest inspector/worker/debugger-scripts.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=165582

Patch by Yury Semikhatsky <[email protected]> on 2019-08-07
Reviewed by Joseph Pecoraro.

Unflake the test. Main resource in the worker target is populated asychronously
when the script is parsed and sent to the debugger, so we need to wait for it
before performing further checks.

* inspector/worker/debugger-scripts.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (248391 => 248392)


--- trunk/LayoutTests/ChangeLog	2019-08-07 21:49:08 UTC (rev 248391)
+++ trunk/LayoutTests/ChangeLog	2019-08-07 21:51:16 UTC (rev 248392)
@@ -1,3 +1,17 @@
+2019-08-07  Yury Semikhatsky  <[email protected]>
+
+        LayoutTest inspector/worker/debugger-scripts.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=165582
+
+        Reviewed by Joseph Pecoraro.
+
+        Unflake the test. Main resource in the worker target is populated asychronously
+        when the script is parsed and sent to the debugger, so we need to wait for it
+        before performing further checks.
+
+        * inspector/worker/debugger-scripts.html:
+        * platform/mac/TestExpectations:
+
 2019-08-07  Russell Epstein  <[email protected]>
 
         Updating TestExpectations for editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html.

Modified: trunk/LayoutTests/inspector/worker/debugger-scripts.html (248391 => 248392)


--- trunk/LayoutTests/inspector/worker/debugger-scripts.html	2019-08-07 21:49:08 UTC (rev 248391)
+++ trunk/LayoutTests/inspector/worker/debugger-scripts.html	2019-08-07 21:51:16 UTC (rev 248392)
@@ -2,6 +2,7 @@
 <html>
 <head>
 <script src=""
+<script src=""
 <script>
 let worker = new Worker("resources/worker-scripts.js");
 
@@ -89,7 +90,7 @@
         }
     });
 
-    suite.runTestCasesAndFinish();
+    awaitTargetMainResource(workerTarget).then(() => suite.runTestCasesAndFinish());
 }
 </script>
 </head>

Modified: trunk/LayoutTests/platform/mac/TestExpectations (248391 => 248392)


--- trunk/LayoutTests/platform/mac/TestExpectations	2019-08-07 21:49:08 UTC (rev 248391)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2019-08-07 21:51:16 UTC (rev 248392)
@@ -1086,7 +1086,6 @@
 webkit.org/b/161361 inspector/unit-tests/yieldable-task.html [ Pass Failure ]
 webkit.org/b/169228 inspector/worker/console-basic.html [ Pass Timeout ]
 webkit.org/b/164872 inspector/worker/debugger-multiple-targets-pause.html [ Pass Failure Timeout ]
-webkit.org/b/165582 inspector/worker/debugger-scripts.html [ Pass Failure ]
 webkit.org/b/167203 inspector/worker/debugger-shared-breakpoint.html [ Pass Failure Timeout ]
 webkit.org/b/155607 inspector/heap/imported-snapshot.html [ Pass Failure ]
 webkit.org/b/155607 inspector/heap/snapshot.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to