Title: [248394] trunk/Source/WebKit
- Revision
- 248394
- Author
- [email protected]
- Date
- 2019-08-07 16:36:27 -0700 (Wed, 07 Aug 2019)
Log Message
Remove speculative workaround for upload crash
https://bugs.webkit.org/show_bug.cgi?id=200514
Patch by Alex Christensen <[email protected]> on 2019-08-07
Reviewed by Geoffrey Garen.
This workaround didn't help anyways, and the crash has been resolved. Let's clean up.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (248393 => 248394)
--- trunk/Source/WebKit/ChangeLog 2019-08-07 22:29:18 UTC (rev 248393)
+++ trunk/Source/WebKit/ChangeLog 2019-08-07 23:36:27 UTC (rev 248394)
@@ -1,3 +1,15 @@
+2019-08-07 Alex Christensen <[email protected]>
+
+ Remove speculative workaround for upload crash
+ https://bugs.webkit.org/show_bug.cgi?id=200514
+
+ Reviewed by Geoffrey Garen.
+
+ This workaround didn't help anyways, and the crash has been resolved. Let's clean up.
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):
+
2019-08-07 Chris Dumez <[email protected]>
Regression(r247784) ResourceLoadStatisticsMemoryStore / ResourceLoadStatisticsPersistentStorage may get destroyed on the wrong thread
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (248393 => 248394)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-08-07 22:29:18 UTC (rev 248393)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-08-07 23:36:27 UTC (rev 248394)
@@ -394,10 +394,7 @@
return;
}
- // FIXME: Call the completionHandler immediately once rdar://problem/28233746 is fixed.
- RunLoop::main().dispatch([body = makeRef(*body), completionHandler = makeBlockPtr(completionHandler)] {
- completionHandler(WebCore::createHTTPBodyNSInputStream(body.get()).get());
- });
+ completionHandler(WebCore::createHTTPBodyNSInputStream(*body).get());
}
#if HAVE(CFNETWORK_WITH_IGNORE_HSTS) && ENABLE(RESOURCE_LOAD_STATISTICS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
