Title: [248396] trunk/Source
- Revision
- 248396
- Author
- [email protected]
- Date
- 2019-08-07 16:52:20 -0700 (Wed, 07 Aug 2019)
Log Message
Adopt non-deprecated CGColorSpace API
https://bugs.webkit.org/show_bug.cgi?id=184358
Patch by Kate Cheney <[email protected]> on 2019-08-07
Reviewed by Darin Adler.
Source/WebCore:
* platform/ScreenProperties.h:
(WebCore::ScreenData::decode):
We changed the deprecated CGColorSpaceCreateWithICCProfile function to
CGColorSpaceCreateWithICCData.
Source/WebKit:
* Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::decode):
We changed the deprecated CGColorSpaceCreateWithICCProfile function to
CGColorSpaceCreateWithICCData.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248395 => 248396)
--- trunk/Source/WebCore/ChangeLog 2019-08-07 23:47:49 UTC (rev 248395)
+++ trunk/Source/WebCore/ChangeLog 2019-08-07 23:52:20 UTC (rev 248396)
@@ -1,3 +1,16 @@
+2019-08-07 Kate Cheney <[email protected]>
+
+ Adopt non-deprecated CGColorSpace API
+ https://bugs.webkit.org/show_bug.cgi?id=184358
+
+ Reviewed by Darin Adler.
+
+ * platform/ScreenProperties.h:
+ (WebCore::ScreenData::decode):
+
+ We changed the deprecated CGColorSpaceCreateWithICCProfile function to
+ CGColorSpaceCreateWithICCData.
+
2019-08-07 Sam Weinig <[email protected]>
[WHLSL] Metal code generation takes a long time uniquing UnnamedTypes
Modified: trunk/Source/WebCore/platform/ScreenProperties.h (248395 => 248396)
--- trunk/Source/WebCore/platform/ScreenProperties.h 2019-08-07 23:47:49 UTC (rev 248395)
+++ trunk/Source/WebCore/platform/ScreenProperties.h 2019-08-07 23:52:20 UTC (rev 248396)
@@ -194,10 +194,7 @@
return WTF::nullopt;
auto colorSpaceData = adoptCF(CFDataCreate(kCFAllocatorDefault, iccData->data(), iccData->size()));
- // FIXME: <http://webkit.org/b/184358> We should switch to CGColorSpaceCreateICCBased.
- ALLOW_DEPRECATED_DECLARATIONS_BEGIN
- cgColorSpace = adoptCF(CGColorSpaceCreateWithICCProfile(colorSpaceData.get()));
- ALLOW_DEPRECATED_DECLARATIONS_END
+ cgColorSpace = adoptCF(CGColorSpaceCreateWithICCData(colorSpaceData.get()));
break;
}
}
Modified: trunk/Source/WebKit/ChangeLog (248395 => 248396)
--- trunk/Source/WebKit/ChangeLog 2019-08-07 23:47:49 UTC (rev 248395)
+++ trunk/Source/WebKit/ChangeLog 2019-08-07 23:52:20 UTC (rev 248396)
@@ -1,3 +1,16 @@
+2019-08-07 Kate Cheney <[email protected]>
+
+ Adopt non-deprecated CGColorSpace API
+ https://bugs.webkit.org/show_bug.cgi?id=184358
+
+ Reviewed by Darin Adler.
+
+ * Shared/mac/ColorSpaceData.mm:
+ (WebKit::ColorSpaceData::decode):
+
+ We changed the deprecated CGColorSpaceCreateWithICCProfile function to
+ CGColorSpaceCreateWithICCData.
+
2019-08-07 Alex Christensen <[email protected]>
Remove speculative workaround for upload crash
Modified: trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm (248395 => 248396)
--- trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm 2019-08-07 23:47:49 UTC (rev 248395)
+++ trunk/Source/WebKit/Shared/mac/ColorSpaceData.mm 2019-08-07 23:52:20 UTC (rev 248396)
@@ -83,9 +83,7 @@
if (!IPC::decode(decoder, data))
return false;
- ALLOW_DEPRECATED_DECLARATIONS_BEGIN
- colorSpaceData.cgColorSpace = adoptCF(CGColorSpaceCreateWithICCProfile(data.get()));
- ALLOW_DEPRECATED_DECLARATIONS_END
+ colorSpaceData.cgColorSpace = adoptCF(CGColorSpaceCreateWithICCData(data.get()));
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
