Title: [248405] trunk/Source/WebCore
- Revision
- 248405
- Author
- [email protected]
- Date
- 2019-08-08 05:08:50 -0700 (Thu, 08 Aug 2019)
Log Message
[GTK] WebKitWebProcess crashes when viewing an HTML with a <video> element referencing unknown file
https://bugs.webkit.org/show_bug.cgi?id=200530
Reviewed by Xabier Rodriguez-Calvar.
Not amenable to unit testing.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248404 => 248405)
--- trunk/Source/WebCore/ChangeLog 2019-08-08 08:20:41 UTC (rev 248404)
+++ trunk/Source/WebCore/ChangeLog 2019-08-08 12:08:50 UTC (rev 248405)
@@ -1,3 +1,15 @@
+2019-08-08 Charlie Turner <[email protected]>
+
+ [GTK] WebKitWebProcess crashes when viewing an HTML with a <video> element referencing unknown file
+ https://bugs.webkit.org/show_bug.cgi?id=200530
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Not amenable to unit testing.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
+
2019-08-07 Saam Barati <[email protected]>
[WHLSL] Prune unreachable stdlib functions after the Checker runs
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (248404 => 248405)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-08-08 08:20:41 UTC (rev 248404)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-08-08 12:08:50 UTC (rev 248405)
@@ -1647,6 +1647,12 @@
void MediaPlayerPrivateGStreamer::fillTimerFired()
{
+ if (m_errorOccured) {
+ GST_DEBUG_OBJECT(pipeline(), "[Buffering] An error occurred, disabling the fill timer");
+ m_fillTimer.stop();
+ return;
+ }
+
GRefPtr<GstQuery> query = adoptGRef(gst_query_new_buffering(GST_FORMAT_PERCENT));
double fillStatus = 100.0;
GstBufferingMode mode = GST_BUFFERING_DOWNLOAD;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
