Title: [248462] trunk/Source
- Revision
- 248462
- Author
- [email protected]
- Date
- 2019-08-08 22:51:44 -0700 (Thu, 08 Aug 2019)
Log Message
[Win] Fix internal build
https://bugs.webkit.org/show_bug.cgi?id=200519
Reviewed by Alex Christensen.
Source/_javascript_Core:
The script 'generate-js-builtins.py' cannot be found when building WebCore. Copy the _javascript_Core Scripts
folder after building JSC.
* _javascript_Core.vcxproj/_javascript_Core.proj:
Source/WebKitLegacy/win:
Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
* WebDownloadCFNet.cpp:
(WebDownload::didFinish):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (248461 => 248462)
--- trunk/Source/_javascript_Core/ChangeLog 2019-08-09 05:01:29 UTC (rev 248461)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-08-09 05:51:44 UTC (rev 248462)
@@ -1,3 +1,15 @@
+2019-08-08 Per Arne Vollan <[email protected]>
+
+ [Win] Fix internal build
+ https://bugs.webkit.org/show_bug.cgi?id=200519
+
+ Reviewed by Alex Christensen.
+
+ The script 'generate-js-builtins.py' cannot be found when building WebCore. Copy the _javascript_Core Scripts
+ folder after building JSC.
+
+ * _javascript_Core.vcxproj/_javascript_Core.proj:
+
2019-08-08 Devin Rousso <[email protected]>
Web Inspector: Page: don't allow the domain to be disabled
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj (248461 => 248462)
--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj 2019-08-09 05:01:29 UTC (rev 248461)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj 2019-08-09 05:51:44 UTC (rev 248462)
@@ -68,6 +68,9 @@
<CreateItem Include="$(ConfigurationBuildDir)\build32\DerivedSources\ForwardingHeaders\_javascript_Core\**\*.*">
<Output TaskParameter="Include" ItemName="IncFiles" />
</CreateItem>
+ <CreateItem Include="$(ConfigurationBuildDir)\include\private\_javascript_Core\Scripts\**\*.*">
+ <Output TaskParameter="Include" ItemName="Scripts" />
+ </CreateItem>
<CreateItem Include="$(ConfigurationBuildDir)\build32\DerivedSources\_javascript_Core\inspector\**\*.*">
<Output TaskParameter="Include" ItemName="InspectorFiles" />
</CreateItem>
@@ -112,6 +115,7 @@
</CreateItem>
<Copy SourceFiles="@(IncFiles)" DestinationFiles="@(IncFiles->'$(DSTROOT)\AppleInternal\include\private\_javascript_Core\%(RecursiveDir)%(Filename)%(Extension)')" />
+ <Copy SourceFiles="@(Scripts)" DestinationFiles="@(Scripts->'$(DSTROOT)\AppleInternal\include\private\_javascript_Core\Scripts\%(RecursiveDir)%(Filename)%(Extension)')" />
<Copy SourceFiles="@(InspectorFiles)" DestinationFiles="@(InspectorFiles->'$(DSTROOT)\AppleInternal\include\private\_javascript_Core\inspector\%(RecursiveDir)%(Filename)%(Extension)')" />
<Copy SourceFiles="@(APIFiles)" DestinationFiles="@(APIFiles->'$(DSTROOT)\AppleInternal\include\_javascript_Core\%(Filename)%(Extension)')" />
<Copy SourceFiles="@(Lib32Files)" DestinationFolder="$(AppleInternalLib32)" />
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (248461 => 248462)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2019-08-09 05:01:29 UTC (rev 248461)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2019-08-09 05:51:44 UTC (rev 248462)
@@ -1,3 +1,15 @@
+2019-08-08 Per Arne Vollan <[email protected]>
+
+ [Win] Fix internal build
+ https://bugs.webkit.org/show_bug.cgi?id=200519
+
+ Reviewed by Alex Christensen.
+
+ Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
+
+ * WebDownloadCFNet.cpp:
+ (WebDownload::didFinish):
+
2019-08-08 Brent Fulgham <[email protected]>
[FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
Modified: trunk/Source/WebKitLegacy/win/WebDownloadCFNet.cpp (248461 => 248462)
--- trunk/Source/WebKitLegacy/win/WebDownloadCFNet.cpp 2019-08-09 05:01:29 UTC (rev 248461)
+++ trunk/Source/WebKitLegacy/win/WebDownloadCFNet.cpp 2019-08-09 05:51:44 UTC (rev 248462)
@@ -467,7 +467,7 @@
// We try to rename the bundle to the final file name. If that fails, we give the delegate one more chance to chose
// the final file name, then we just leave it
- if (!MoveFileEx(m_bundlePath.charactersWithNullTermination().data(), m_destination.charactersWithNullTermination().data(), 0)) {
+ if (!MoveFileEx(m_bundlePath.wideCharacters().data(), m_destination.wideCharacters().data(), 0)) {
LOG_ERROR("Failed to move bundle %s to %s on completion\nError - %i", m_bundlePath.ascii().data(), m_destination.ascii().data(), GetLastError());
bool reportBundlePathAsFinalPath = true;
@@ -479,7 +479,7 @@
// The call to m_delegate->decideDestinationWithSuggestedFilename() should have changed our destination, so we'll try the move
// one last time.
if (!m_destination.isEmpty())
- if (MoveFileEx(m_bundlePath.charactersWithNullTermination().data(), m_destination.charactersWithNullTermination().data(), 0))
+ if (MoveFileEx(m_bundlePath.wideCharacters().data(), m_destination.wideCharacters().data(), 0))
reportBundlePathAsFinalPath = false;
// We either need to tell the delegate our final filename is the bundle filename, or is the file name they just told us to use
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
