Diff
Modified: trunk/Source/WebInspectorUI/.eslintrc (248536 => 248537)
--- trunk/Source/WebInspectorUI/.eslintrc 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/.eslintrc 2019-08-12 18:49:06 UTC (rev 248537)
@@ -38,6 +38,7 @@
"AuditAgent": true,
"ApplicationCacheAgent": true,
"CSSAgent": true,
+ "CPUProfilerAgent": true,
"CanvasAgent": true,
"ConsoleAgent": true,
"DOMAgent": true,
@@ -56,6 +57,7 @@
"RuntimeAgent": true,
"ScriptProfilerAgent": true,
"ServiceWorkerAgent": true,
+ "TargetAgent": true,
"TimelineAgent": true,
"WorkerAgent": true,
@@ -109,6 +111,7 @@
// Utilities
"appendWebInspectorConsoleEvaluationSourceURL": true,
"appendWebInspectorSourceURL": true,
+ "blobAsText": true,
"clamp": true,
"doubleQuotedString": true,
"ellipsis": true,
Modified: trunk/Source/WebInspectorUI/ChangeLog (248536 => 248537)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-12 18:49:06 UTC (rev 248537)
@@ -1,5 +1,32 @@
2019-08-09 Joseph Pecoraro <[email protected]>
+ Web Inspector: Address some ESLint warnings
+ https://bugs.webkit.org/show_bug.cgi?id=200598
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Base/Utilities.js:
+ * UserInterface/Controllers/TimelineManager.js:
+ * UserInterface/Models/DOMNodeStyles.js:
+ * UserInterface/Models/LayoutTimelineRecord.js:
+ * UserInterface/Models/ServerTimingEntry.js:
+ * UserInterface/Models/TimelineRecording.js:
+ * UserInterface/Protocol/RemoteObject.js:
+ * UserInterface/Test/FrontendTestHarness.js:
+ * UserInterface/Test/Test.js:
+ * UserInterface/Views/CPUTimelineView.js:
+ * UserInterface/Views/CPUUsageCombinedView.js:
+ * UserInterface/Views/ChangesDetailsSidebarPanel.js:
+ * UserInterface/Views/DOMTreeContentView.js:
+ * UserInterface/Views/DOMTreeElement.js:
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ * UserInterface/Views/NetworkTableContentView.js:
+ * UserInterface/Views/ResourceTimingBreakdownView.js:
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+ * UserInterface/Views/TreeOutline.js:
+
+2019-08-09 Joseph Pecoraro <[email protected]>
+
Web Inspector: Better organize manager / observer API groups
https://bugs.webkit.org/show_bug.cgi?id=200594
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -1651,7 +1651,7 @@
if (startRatio < autoFormatWhitespaceRatio)
return true;
- let endRatio = whitespaceRatio(content, content.length - autoFormatMaxCharactersToCheck, content.length)
+ let endRatio = whitespaceRatio(content, content.length - autoFormatMaxCharactersToCheck, content.length);
if (endRatio < autoFormatWhitespaceRatio)
return true;
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -332,7 +332,7 @@
return;
}
- if (!json.recording || typeof json.recording !== "object" || !json.overview || typeof json.overview !== "object" || typeof json.version !== "number") {
+ if (!json.recording || typeof json.recording !== "object" || !json.overview || typeof json.overview !== "object" || typeof json.version !== "number") {
WI.TimelineManager.synthesizeImportError(WI.UIString("invalid JSON"));
return;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -301,7 +301,7 @@
}
}
- this._includeUserAgentRulesOnNextRefresh = false
+ this._includeUserAgentRulesOnNextRefresh = false;
this.dispatchEventToListeners(WI.DOMNodeStyles.Event.Refreshed, {significantChange});
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -81,7 +81,7 @@
startTime: this.startTime,
endTime: this.endTime,
quad: this._quad || undefined,
- }
+ };
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ServerTimingEntry.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ServerTimingEntry.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ServerTimingEntry.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -156,7 +156,7 @@
if (parseParameter)
parseParameter(paramValue, entry);
else
- console.warn("Unknown Server-Timing parameter:", paramName, paramValue)
+ console.warn("Unknown Server-Timing parameter:", paramName, paramValue);
}
entries.push(entry);
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -247,7 +247,7 @@
this._firstRecordOfTypeAfterDiscontinuity.clear();
this._exportDataRecords = [];
- this._exportDataMarkers = []
+ this._exportDataMarkers = [];
this._exportDataMemoryPressureEvents = [];
this._exportDataSampleStackTraces = [];
this._exportDataSampleDurations = [];
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -462,7 +462,7 @@
callback(0);
}
- async fetchProperties(propertyNames, resultObject={})
+ async fetchProperties(propertyNames, resultObject = {})
{
let seenPropertyNames = new Set;
let requestedValues = [];
Modified: trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -77,7 +77,7 @@
this.evaluateInPage(`TestPage.debugLog(unescape("${escape(stringifiedMessage)}"));`);
}
- evaluateInPage(_expression_, callback, options={})
+ evaluateInPage(_expression_, callback, options = {})
{
let remoteObjectOnly = !!options.remoteObjectOnly;
Modified: trunk/Source/WebInspectorUI/UserInterface/Test/Test.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Test/Test.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/Test.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -207,7 +207,7 @@
RTL: "rtl",
};
-WI.resolvedLayoutDirection = () => { return InspectorFrontendHost.userInterfaceLayoutDirection(); }
+WI.resolvedLayoutDirection = () => { return InspectorFrontendHost.userInterfaceLayoutDirection(); };
// Add stubs that are called by the frontend API.
WI.updateDockedState = () => {};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -1289,7 +1289,6 @@
if (recordEnd < millisecondStartTime)
continue;
- let offset = recordStart - millisecondStartTime;
recordStart = Math.max(recordStart, millisecondStartTime);
recordEnd = Math.min(recordEnd, millisecondEndTime);
@@ -1420,7 +1419,7 @@
this._layoutStatisticsAndSources();
});
return span;
- }
+ };
this._sourcesFilterRow.hidden = false;
this._sourcesFilterLabelElement.removeChildren();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageCombinedView.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageCombinedView.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageCombinedView.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -138,7 +138,7 @@
let x = xScale(dataPoint.time);
let y1 = yScale(dataPoint.mainThreadUsage);
let y2 = yScale(dataPoint.mainThreadUsage + dataPoint.workerThreadUsage);
- let y3 = yScale(dataPoint.usage)
+ let y3 = yScale(dataPoint.usage);
this._chart.addPointSet(x, [y1, y2, y3]);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -92,7 +92,7 @@
return true;
if (style.ownerRule)
- return stylesForNode.matchedRules.some((matchedRule) => style.ownerRule.isEqualTo(matchedRule))
+ return stylesForNode.matchedRules.some((matchedRule) => style.ownerRule.isEqualTo(matchedRule));
return false;
});
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -694,7 +694,7 @@
}
console.assert(appearanceToForce);
- WI.cssManager.forcedAppearance = WI.cssManager.forcedAppearance == appearanceToForce ? null : appearanceToForce;
+ WI.cssManager.forcedAppearance = WI.cssManager.forcedAppearance === appearanceToForce ? null : appearanceToForce;
// When no longer forcing an appearance, if the last known default appearance is different than the current
// default appearance, then update the navigation button now. Otherwise just toggle the activated state.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -1937,7 +1937,7 @@
return;
let shouldEnable = breakpoints.some((breakpoint) => breakpoint.disabled);
- breakpoints.forEach((breakpoint) => breakpoint.disabled = !shouldEnable);
+ breakpoints.forEach((breakpoint) => { breakpoint.disabled = !shouldEnable });
}
_statusImageContextmenu(event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -343,7 +343,7 @@
createContentTreeOutline(options = {})
{
- let treeOutline = super.createContentTreeOutline(options)
+ let treeOutline = super.createContentTreeOutline(options);
treeOutline.addEventListener(WI.TreeOutline.Event.ElementRevealed, (event) => {
let treeElement = event.data.element;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -360,7 +360,7 @@
tableRepresentedObjectForIndex(table, index)
{
- console.assert(index >=0 && index < this._activeCollection.filteredEntries.length);
+ console.assert(index >= 0 && index < this._activeCollection.filteredEntries.length);
return this._activeCollection.filteredEntries[index];
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -178,7 +178,7 @@
this._appendHeaderRow(WI.UIString("Start to Finish"), Number.secondsToMillisecondsString(responseEnd - startTime), "total-row");
if (serverTiming.length > 0) {
- this._appendDividerRow()
+ this._appendDividerRow();
this._appendHeaderRow(WI.UIString("Server Timing:"));
let maxDuration = serverTiming.reduce((max, {duration = 0}) => Math.max(max, duration), 0);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -361,7 +361,7 @@
deselectProperties()
{
- for (let propertyView of this._propertyViews)
+ for (let propertyView of this._propertyViews)
propertyView.selected = false;
this._focused = false;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (248536 => 248537)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-08-12 18:45:13 UTC (rev 248536)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-08-12 18:49:06 UTC (rev 248537)
@@ -729,19 +729,6 @@
this._selectionController.selectItems(new Set(selectableObjects));
}
- get selectedTreeElementIndex()
- {
- if (!this.hasChildren || !this.selectedTreeElement)
- return;
-
- for (var i = 0; i < this.children.length; ++i) {
- if (this.children[i] === this.selectedTreeElement)
- return i;
- }
-
- return false;
- }
-
get virtualized()
{
return this._virtualizedScrollContainer && !isNaN(this._virtualizedTreeItemHeight);
