Title: [248539] trunk/Source/WebInspectorUI
- Revision
- 248539
- Author
- [email protected]
- Date
- 2019-08-12 12:17:56 -0700 (Mon, 12 Aug 2019)
Log Message
Web Inspector: Elements: Styles: add space between media query and style icon
https://bugs.webkit.org/show_bug.cgi?id=200623
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(.spreadsheet-css-declaration .header:not(:first-child), .spreadsheet-css-declaration .header:not(.editing-selector) .selector, .spreadsheet-css-declaration.has-icon .header.editing-selector .selector): Added.
(.spreadsheet-css-declaration .header.editing-selector .selector): Deleted.
Ensure the selector field doesn't shift vertically when entering/exiting editing mode.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248538 => 248539)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-12 19:13:17 UTC (rev 248538)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-12 19:17:56 UTC (rev 248539)
@@ -1,3 +1,17 @@
+2019-08-12 Devin Rousso <[email protected]>
+
+ Web Inspector: Elements: Styles: add space between media query and style icon
+ https://bugs.webkit.org/show_bug.cgi?id=200623
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+ (WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
+ (.spreadsheet-css-declaration .header:not(:first-child), .spreadsheet-css-declaration .header:not(.editing-selector) .selector, .spreadsheet-css-declaration.has-icon .header.editing-selector .selector): Added.
+ (.spreadsheet-css-declaration .header.editing-selector .selector): Deleted.
+ Ensure the selector field doesn't shift vertically when entering/exiting editing mode.
+
2019-08-09 Joseph Pecoraro <[email protected]>
Web Inspector: Address some ESLint warnings
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css (248538 => 248539)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css 2019-08-12 19:13:17 UTC (rev 248538)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css 2019-08-12 19:17:56 UTC (rev 248539)
@@ -47,7 +47,9 @@
padding-top: var(--css-declaration-vertical-padding);
}
-.spreadsheet-css-declaration .header.editing-selector .selector {
+.spreadsheet-css-declaration .header:not(:first-child),
+.spreadsheet-css-declaration .header:not(.editing-selector) .selector,
+.spreadsheet-css-declaration.has-icon .header.editing-selector .selector {
margin-top: 1px;
}
@@ -172,3 +174,4 @@
color: var(--text-color-secondary);
}
}
+
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js (248538 => 248539)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js 2019-08-12 19:13:17 UTC (rev 248538)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js 2019-08-12 19:17:56 UTC (rev 248539)
@@ -96,7 +96,7 @@
break;
}
console.assert(iconClassName);
- this._element.classList.add(iconClassName);
+ this._element.classList.add("has-icon", iconClassName);
}
this._headerElement = document.createElement("div");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
