Log Message
Remove an assertion in ~StorageArea() https://bugs.webkit.org/show_bug.cgi?id=200630 <rdar://problem/54097722>
Reviewed by Chris Dumez. In r247370, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to make sure StorageArea gets destroyed on the background thread. StorageArea can get destroyed before LocalStorageNamespace, so the assertion in ~StorageArea() is not true any more. * NetworkProcess/WebStorage/StorageArea.cpp: (WebKit::StorageArea::~StorageArea):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (248541 => 248542)
--- trunk/Source/WebKit/ChangeLog 2019-08-12 19:31:21 UTC (rev 248541)
+++ trunk/Source/WebKit/ChangeLog 2019-08-12 19:33:53 UTC (rev 248542)
@@ -1,3 +1,19 @@
+2019-08-12 Sihui Liu <[email protected]>
+
+ Remove an assertion in ~StorageArea()
+ https://bugs.webkit.org/show_bug.cgi?id=200630
+ <rdar://problem/54097722>
+
+ Reviewed by Chris Dumez.
+
+ In r247370, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to
+ make sure StorageArea gets destroyed on the background thread.
+ StorageArea can get destroyed before LocalStorageNamespace, so the assertion in ~StorageArea() is not true any
+ more.
+
+ * NetworkProcess/WebStorage/StorageArea.cpp:
+ (WebKit::StorageArea::~StorageArea):
+
2019-08-12 Wenson Hsieh <[email protected]>
[iPadOS] Web pages sometimes load at half width in Safari
Modified: trunk/Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp (248541 => 248542)
--- trunk/Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp 2019-08-12 19:31:21 UTC (rev 248541)
+++ trunk/Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp 2019-08-12 19:33:53 UTC (rev 248542)
@@ -49,7 +49,6 @@
{
ASSERT(!RunLoop::isMain());
ASSERT(m_eventListeners.isEmpty());
- ASSERT(!m_localStorageNamespace);
if (m_localStorageDatabase)
m_localStorageDatabase->close();
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
