- Revision
- 248547
- Author
- [email protected]
- Date
- 2019-08-12 14:37:16 -0700 (Mon, 12 Aug 2019)
Log Message
[WPE][GTK] Fix building without unified sources
https://bugs.webkit.org/show_bug.cgi?id=200641
Reviewed by Žan Doberšek.
Source/_javascript_Core:
* b3/B3PatchpointSpecial.cpp: Add missing inclusion of the B3ProcedureInlines.h header.
* heap/SlotVisitor.cpp: Add missing inclusion of the BlockDirectoryInlines.h header.
Source/WebCore:
* CMakeLists.txt: Add WebCore as the list of libraries to link into WebCoreTestSupport, to
avoid underlinking, which makes it possible to link with LDFLAGS="-Wl,--no-undefined".
* editing/WebCorePasteboardFileReader.h: Add missing inclusion of the pal/SessionID.h
header.
Source/WebKit:
* UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp: Add missing inclusions for headers
WebCore/GtkUtilities.h (for convertWidgetPointToScreenPoint), WebCore/IntPoint.h, and
WebPageProxy.h (the two latter to avoid usage of undefined types).
(WebKit::WebDataListSuggestionsDropdownGtk::show): Add namespace prefix to use
WebCore::IntPoint.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (248546 => 248547)
--- trunk/Source/_javascript_Core/ChangeLog 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-08-12 21:37:16 UTC (rev 248547)
@@ -1,3 +1,13 @@
+2019-08-12 Adrian Perez de Castro <[email protected]>
+
+ [WPE][GTK] Fix building without unified sources
+ https://bugs.webkit.org/show_bug.cgi?id=200641
+
+ Reviewed by Žan Doberšek.
+
+ * b3/B3PatchpointSpecial.cpp: Add missing inclusion of the B3ProcedureInlines.h header.
+ * heap/SlotVisitor.cpp: Add missing inclusion of the BlockDirectoryInlines.h header.
+
2019-08-12 Yusuke Suzuki <[email protected]>
[WTF][JSC] Make JSC and WTF aggressively-fast-malloced
Modified: trunk/Source/_javascript_Core/b3/B3PatchpointSpecial.cpp (248546 => 248547)
--- trunk/Source/_javascript_Core/b3/B3PatchpointSpecial.cpp 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/_javascript_Core/b3/B3PatchpointSpecial.cpp 2019-08-12 21:37:16 UTC (rev 248547)
@@ -30,6 +30,7 @@
#include "AirCode.h"
#include "AirGenerationContext.h"
+#include "B3ProcedureInlines.h"
#include "B3StackmapGenerationParams.h"
#include "B3ValueInlines.h"
Modified: trunk/Source/_javascript_Core/heap/SlotVisitor.cpp (248546 => 248547)
--- trunk/Source/_javascript_Core/heap/SlotVisitor.cpp 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/_javascript_Core/heap/SlotVisitor.cpp 2019-08-12 21:37:16 UTC (rev 248547)
@@ -26,6 +26,7 @@
#include "config.h"
#include "SlotVisitor.h"
+#include "BlockDirectoryInlines.h"
#include "CPU.h"
#include "ConservativeRoots.h"
#include "GCSegmentedArrayInlines.h"
Modified: trunk/Source/WebCore/CMakeLists.txt (248546 => 248547)
--- trunk/Source/WebCore/CMakeLists.txt 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/WebCore/CMakeLists.txt 2019-08-12 21:37:16 UTC (rev 248547)
@@ -1211,6 +1211,7 @@
)
set(WebCoreTestSupport_LIBRARIES
+ WebCore
WebKit::_javascript_Core
)
Modified: trunk/Source/WebCore/ChangeLog (248546 => 248547)
--- trunk/Source/WebCore/ChangeLog 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/WebCore/ChangeLog 2019-08-12 21:37:16 UTC (rev 248547)
@@ -1,3 +1,15 @@
+2019-08-12 Adrian Perez de Castro <[email protected]>
+
+ [WPE][GTK] Fix building without unified sources
+ https://bugs.webkit.org/show_bug.cgi?id=200641
+
+ Reviewed by Žan Doberšek.
+
+ * CMakeLists.txt: Add WebCore as the list of libraries to link into WebCoreTestSupport, to
+ avoid underlinking, which makes it possible to link with LDFLAGS="-Wl,--no-undefined".
+ * editing/WebCorePasteboardFileReader.h: Add missing inclusion of the pal/SessionID.h
+ header.
+
2019-08-12 Yusuke Suzuki <[email protected]>
[WTF][JSC] Make JSC and WTF aggressively-fast-malloced
Modified: trunk/Source/WebCore/editing/WebCorePasteboardFileReader.h (248546 => 248547)
--- trunk/Source/WebCore/editing/WebCorePasteboardFileReader.h 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/WebCore/editing/WebCorePasteboardFileReader.h 2019-08-12 21:37:16 UTC (rev 248547)
@@ -26,6 +26,7 @@
#pragma once
#include "Pasteboard.h"
+#include <pal/SessionID.h>
namespace WebCore {
Modified: trunk/Source/WebKit/ChangeLog (248546 => 248547)
--- trunk/Source/WebKit/ChangeLog 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/WebKit/ChangeLog 2019-08-12 21:37:16 UTC (rev 248547)
@@ -1,3 +1,16 @@
+2019-08-12 Adrian Perez de Castro <[email protected]>
+
+ [WPE][GTK] Fix building without unified sources
+ https://bugs.webkit.org/show_bug.cgi?id=200641
+
+ Reviewed by Žan Doberšek.
+
+ * UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp: Add missing inclusions for headers
+ WebCore/GtkUtilities.h (for convertWidgetPointToScreenPoint), WebCore/IntPoint.h, and
+ WebPageProxy.h (the two latter to avoid usage of undefined types).
+ (WebKit::WebDataListSuggestionsDropdownGtk::show): Add namespace prefix to use
+ WebCore::IntPoint.
+
2019-08-12 Sihui Liu <[email protected]>
Clear m_sessionStorageNamespaces on the background thread
Modified: trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp (248546 => 248547)
--- trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp 2019-08-12 20:57:15 UTC (rev 248546)
+++ trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp 2019-08-12 21:37:16 UTC (rev 248547)
@@ -28,7 +28,10 @@
#if ENABLE(DATALIST_ELEMENT)
+#include "WebPageProxy.h"
#include <WebCore/DataListSuggestionInformation.h>
+#include <WebCore/GtkUtilities.h>
+#include <WebCore/IntPoint.h>
#include <wtf/glib/GRefPtr.h>
#include <wtf/glib/GUniquePtr.h>
@@ -149,7 +152,7 @@
GtkRequisition menuRequisition;
gtk_widget_get_preferred_size(m_popup, &menuRequisition, nullptr);
- IntPoint menuPosition = convertWidgetPointToScreenPoint(m_webView, information.elementRect.location());
+ WebCore::IntPoint menuPosition = convertWidgetPointToScreenPoint(m_webView, information.elementRect.location());
// FIXME: We can't ensure the menu will be on screen in Wayland.
// https://blog.gtk.org/2016/07/15/future-of-relative-window-positioning/
// https://gitlab.gnome.org/GNOME/gtk/issues/997
