Title: [248550] trunk/Source/WebKit
- Revision
- 248550
- Author
- [email protected]
- Date
- 2019-08-12 15:23:03 -0700 (Mon, 12 Aug 2019)
Log Message
Contextual menu Hide and Show Link Previews should not have a symbol
https://bugs.webkit.org/show_bug.cgi?id=200645
<rdar://problem/54129647>
Reviewed by Wenson Hsieh.
Don't use an image on the UIMenuItem.
* UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (248549 => 248550)
--- trunk/Source/WebKit/ChangeLog 2019-08-12 21:43:00 UTC (rev 248549)
+++ trunk/Source/WebKit/ChangeLog 2019-08-12 22:23:03 UTC (rev 248550)
@@ -1,3 +1,16 @@
+2019-08-12 Dean Jackson <[email protected]>
+
+ Contextual menu Hide and Show Link Previews should not have a symbol
+ https://bugs.webkit.org/show_bug.cgi?id=200645
+ <rdar://problem/54129647>
+
+ Reviewed by Wenson Hsieh.
+
+ Don't use an image on the UIMenuItem.
+
+ * UIProcess/API/Cocoa/_WKElementAction.mm:
+ (+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.
+
2019-08-12 Chris Dumez <[email protected]>
Unreviewed, add missing WTF::initializeMainThread() call to fix some crashes on the bots after r248533.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm (248549 => 248550)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2019-08-12 21:43:00 UTC (rev 248549)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2019-08-12 22:23:03 UTC (rev 248550)
@@ -240,7 +240,7 @@
case _WKElementActionTypeDownload:
return [UIImage systemImageNamed:@"arrow.down.circle"];
case _WKElementActionToggleShowLinkPreviews:
- return [UIImage systemImageNamed:@"safari"];
+ return nil; // Intentionally empty.
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
