Title: [248590] trunk/Source/WebInspectorUI
- Revision
- 248590
- Author
- [email protected]
- Date
- 2019-08-12 20:56:37 -0700 (Mon, 12 Aug 2019)
Log Message
REGRESSION(r248391): Web Inspector: changing Layout Direction Debug setting no longer adds dir="ltr" to body element
https://bugs.webkit.org/show_bug.cgi?id=200564
Reviewed by Joseph Pecoraro.
`WI.resolvedLayoutDirection` was called before `WI.runBootstrapOperations`, which is what
instantiates `WI.showDebugUISetting`. Without it, `WI.resolvedLayoutDirection` will ignore
the value of `WI.settings.debugLayoutDirection` and instead use the system.
Moving the instantiation of `WI.showDebugUISetting` outside `WI.runBootstrapOperations`
allows the setting to be created when the Bootstrap.js script is loaded, rather than after
the `DOMContentLoaded` event is fired. This means that it's guaranteed to exist before any
interface/view code runs.
* UserInterface/Debug/Bootstrap.js:
(WI.runBootstrapOperations):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248589 => 248590)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-13 03:54:38 UTC (rev 248589)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-13 03:56:37 UTC (rev 248590)
@@ -1,5 +1,24 @@
2019-08-12 Devin Rousso <[email protected]>
+ REGRESSION(r248391): Web Inspector: changing Layout Direction Debug setting no longer adds dir="ltr" to body element
+ https://bugs.webkit.org/show_bug.cgi?id=200564
+
+ Reviewed by Joseph Pecoraro.
+
+ `WI.resolvedLayoutDirection` was called before `WI.runBootstrapOperations`, which is what
+ instantiates `WI.showDebugUISetting`. Without it, `WI.resolvedLayoutDirection` will ignore
+ the value of `WI.settings.debugLayoutDirection` and instead use the system.
+
+ Moving the instantiation of `WI.showDebugUISetting` outside `WI.runBootstrapOperations`
+ allows the setting to be created when the Bootstrap.js script is loaded, rather than after
+ the `DOMContentLoaded` event is fired. This means that it's guaranteed to exist before any
+ interface/view code runs.
+
+ * UserInterface/Debug/Bootstrap.js:
+ (WI.runBootstrapOperations):
+
+2019-08-12 Devin Rousso <[email protected]>
+
Web Inspector: remove WI.DeprecatedRemoteObjectProperty
https://bugs.webkit.org/show_bug.cgi?id=200549
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js (248589 => 248590)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2019-08-13 03:54:38 UTC (rev 248589)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2019-08-13 03:56:37 UTC (rev 248590)
@@ -37,10 +37,10 @@
WI.settings.engineeringShowInternalScripts.value = true;
}, WI.settings.engineeringShowInternalScripts);
+WI.showDebugUISetting = new WI.Setting("show-debug-ui", false);
+
// This function is invoked after the inspector has loaded and has a backend target.
WI.runBootstrapOperations = function() {
- WI.showDebugUISetting = new WI.Setting("show-debug-ui", false);
-
// Toggle Debug UI setting.
new WI.KeyboardShortcut(WI.KeyboardShortcut.Modifier.Option | WI.KeyboardShortcut.Modifier.Shift | WI.KeyboardShortcut.Modifier.CommandOrControl, "D", () => {
WI.showDebugUISetting.value = !WI.showDebugUISetting.value;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
