Title: [248623] branches/safari-608-branch/Source/WebKit
- Revision
- 248623
- Author
- [email protected]
- Date
- 2019-08-13 13:01:24 -0700 (Tue, 13 Aug 2019)
Log Message
Cherry-pick r248550. rdar://problem/54237677
Contextual menu Hide and Show Link Previews should not have a symbol
https://bugs.webkit.org/show_bug.cgi?id=200645
<rdar://problem/54129647>
Reviewed by Wenson Hsieh.
Don't use an image on the UIMenuItem.
* UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (248622 => 248623)
--- branches/safari-608-branch/Source/WebKit/ChangeLog 2019-08-13 20:01:22 UTC (rev 248622)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog 2019-08-13 20:01:24 UTC (rev 248623)
@@ -1,5 +1,35 @@
2019-08-13 Alan Coon <[email protected]>
+ Cherry-pick r248550. rdar://problem/54237677
+
+ Contextual menu Hide and Show Link Previews should not have a symbol
+ https://bugs.webkit.org/show_bug.cgi?id=200645
+ <rdar://problem/54129647>
+
+ Reviewed by Wenson Hsieh.
+
+ Don't use an image on the UIMenuItem.
+
+ * UIProcess/API/Cocoa/_WKElementAction.mm:
+ (+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-08-12 Dean Jackson <[email protected]>
+
+ Contextual menu Hide and Show Link Previews should not have a symbol
+ https://bugs.webkit.org/show_bug.cgi?id=200645
+ <rdar://problem/54129647>
+
+ Reviewed by Wenson Hsieh.
+
+ Don't use an image on the UIMenuItem.
+
+ * UIProcess/API/Cocoa/_WKElementAction.mm:
+ (+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.
+
+2019-08-13 Alan Coon <[email protected]>
+
Cherry-pick r248541. rdar://problem/54237768
[iPadOS] Web pages sometimes load at half width in Safari
Modified: branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm (248622 => 248623)
--- branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2019-08-13 20:01:22 UTC (rev 248622)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2019-08-13 20:01:24 UTC (rev 248623)
@@ -240,7 +240,7 @@
case _WKElementActionTypeDownload:
return [UIImage systemImageNamed:@"arrow.down.circle"];
case _WKElementActionToggleShowLinkPreviews:
- return [UIImage systemImageNamed:@"safari"];
+ return nil; // Intentionally empty.
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
