Title: [248678] trunk/Tools
Revision
248678
Author
jbed...@apple.com
Date
2019-08-14 11:05:23 -0700 (Wed, 14 Aug 2019)

Log Message

results.webkit.org: Don't save configuration multiple times in upload
https://bugs.webkit.org/show_bug.cgi?id=200719

Reviewed by Aakash Jain.

* resultsdbpy/resultsdbpy/model/upload_context.py:
(UploadContext.upload_test_results): Move registering of the configuration out
of the branch loop.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (248677 => 248678)


--- trunk/Tools/ChangeLog	2019-08-14 17:24:17 UTC (rev 248677)
+++ trunk/Tools/ChangeLog	2019-08-14 18:05:23 UTC (rev 248678)
@@ -1,3 +1,14 @@
+2019-08-14  Jonathan Bedard  <jbed...@apple.com>
+
+        results.webkit.org: Don't save configuration multiple times in upload
+        https://bugs.webkit.org/show_bug.cgi?id=200719
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/model/upload_context.py:
+        (UploadContext.upload_test_results): Move registering of the configuration out
+        of the branch loop.
+
 2019-08-14  Youenn Fablet  <you...@apple.com>
 
         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension

Modified: trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py (248677 => 248678)


--- trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py	2019-08-14 17:24:17 UTC (rev 248677)
+++ trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py	2019-08-14 18:05:23 UTC (rev 248678)
@@ -227,8 +227,9 @@
         branches = self.commit_context.branch_keys_for_commits(commits)
 
         with self:
+            self.configuration_context.register_configuration(configuration, timestamp=timestamp)
+
             for branch in branches:
-                self.configuration_context.register_configuration(configuration, timestamp=timestamp)
                 self.configuration_context.insert_row_with_configuration(
                     self.SuitesByConfiguration.__table_name__, configuration, suite=suite,
                     ttl=int((uuid // Commit.TIMESTAMP_TO_UUID_MULTIPLIER) + self.ttl_seconds - time.time()) if self.ttl_seconds else None,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to