Title: [248680] trunk/Source/_javascript_Core
- Revision
- 248680
- Author
- pecor...@apple.com
- Date
- 2019-08-14 11:20:17 -0700 (Wed, 14 Aug 2019)
Log Message
Web Inspector: Remove bad semicolon in generation of ObjC methods
https://bugs.webkit.org/show_bug.cgi?id=200655
Reviewed by Devin Rousso.
* inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:
(ObjCFrontendDispatcherImplementationGenerator._generate_event_dispatcher_implementations):
Do not include a semicolon in the method implementation.
* inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
* inspector/scripts/tests/generic/expected/enum-values.json-result:
* inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
* inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Updated results.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (248679 => 248680)
--- trunk/Source/_javascript_Core/ChangeLog 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-08-14 18:20:17 UTC (rev 248680)
@@ -1,3 +1,21 @@
+2019-08-14 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Remove bad semicolon in generation of ObjC methods
+ https://bugs.webkit.org/show_bug.cgi?id=200655
+
+ Reviewed by Devin Rousso.
+
+ * inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:
+ (ObjCFrontendDispatcherImplementationGenerator._generate_event_dispatcher_implementations):
+ Do not include a semicolon in the method implementation.
+
+ * inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
+ * inspector/scripts/tests/generic/expected/enum-values.json-result:
+ * inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
+ * inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
+ * inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
+ Updated results.
+
2019-08-13 Saam Barati <sbar...@apple.com>
Add a way to opt out of kern TCSM for layout tests
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py (248679 => 248680)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py 2019-08-14 18:20:17 UTC (rev 248680)
@@ -83,7 +83,7 @@
lines.append(' AugmentableInspectorController* _controller;')
lines.append('}')
lines.append('')
- lines.append('- (instancetype)initWithController:(AugmentableInspectorController*)controller;')
+ lines.append('- (instancetype)initWithController:(AugmentableInspectorController*)controller')
lines.append('{')
lines.append(' self = [super init];')
lines.append(' if (!self)')
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result (248679 => 248680)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result 2019-08-14 18:20:17 UTC (rev 248680)
@@ -836,7 +836,7 @@
AugmentableInspectorController* _controller;
}
-- (instancetype)initWithController:(AugmentableInspectorController*)controller;
+- (instancetype)initWithController:(AugmentableInspectorController*)controller
{
self = [super init];
if (!self)
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/enum-values.json-result (248679 => 248680)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/enum-values.json-result 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/enum-values.json-result 2019-08-14 18:20:17 UTC (rev 248680)
@@ -880,7 +880,7 @@
AugmentableInspectorController* _controller;
}
-- (instancetype)initWithController:(AugmentableInspectorController*)controller;
+- (instancetype)initWithController:(AugmentableInspectorController*)controller
{
self = [super init];
if (!self)
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result (248679 => 248680)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result 2019-08-14 18:20:17 UTC (rev 248680)
@@ -766,7 +766,7 @@
AugmentableInspectorController* _controller;
}
-- (instancetype)initWithController:(AugmentableInspectorController*)controller;
+- (instancetype)initWithController:(AugmentableInspectorController*)controller
{
self = [super init];
if (!self)
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result (248679 => 248680)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result 2019-08-14 18:20:17 UTC (rev 248680)
@@ -863,7 +863,7 @@
AugmentableInspectorController* _controller;
}
-- (instancetype)initWithController:(AugmentableInspectorController*)controller;
+- (instancetype)initWithController:(AugmentableInspectorController*)controller
{
self = [super init];
if (!self)
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result (248679 => 248680)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result 2019-08-14 18:13:39 UTC (rev 248679)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result 2019-08-14 18:20:17 UTC (rev 248680)
@@ -836,7 +836,7 @@
AugmentableInspectorController* _controller;
}
-- (instancetype)initWithController:(AugmentableInspectorController*)controller;
+- (instancetype)initWithController:(AugmentableInspectorController*)controller
{
self = [super init];
if (!self)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
