Title: [248683] trunk/Source/WebInspectorUI
- Revision
- 248683
- Author
- drou...@apple.com
- Date
- 2019-08-14 11:45:05 -0700 (Wed, 14 Aug 2019)
Log Message
Web Inspector: Elements: Computed: move the Box Model section to the top
https://bugs.webkit.org/show_bug.cgi?id=200555
Reviewed by Joseph Pecoraro.
For nodes that use a lot of different CSS properties, having the Box Model section all the
way at the bottom isn't as useful for taking a quick glance at the node's box model data.
* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.initialLayout):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248682 => 248683)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-14 18:43:07 UTC (rev 248682)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-14 18:45:05 UTC (rev 248683)
@@ -1,5 +1,18 @@
2019-08-14 Devin Rousso <drou...@apple.com>
+ Web Inspector: Elements: Computed: move the Box Model section to the top
+ https://bugs.webkit.org/show_bug.cgi?id=200555
+
+ Reviewed by Joseph Pecoraro.
+
+ For nodes that use a lot of different CSS properties, having the Box Model section all the
+ way at the bottom isn't as useful for taking a quick glance at the node's box model data.
+
+ * UserInterface/Views/ComputedStyleDetailsPanel.js:
+ (WI.ComputedStyleDetailsPanel.prototype.initialLayout):
+
+2019-08-14 Devin Rousso <drou...@apple.com>
+
Web Inspector: Elements: Computed: the collapsed state of the Variables section should be separate from the collapsed state of the Properties section
https://bugs.webkit.org/show_bug.cgi?id=200725
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js (248682 => 248683)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2019-08-14 18:43:07 UTC (rev 248682)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2019-08-14 18:45:05 UTC (rev 248683)
@@ -82,6 +82,13 @@
initialLayout()
{
+ this._boxModelDiagramRow = new WI.BoxModelDetailsSectionRow;
+
+ let boxModelGroup = new WI.DetailsSectionGroup([this._boxModelDiagramRow]);
+ let boxModelSection = new WI.DetailsSection("computed-style-box-model", WI.UIString("Box Model"), [boxModelGroup]);
+
+ this.element.appendChild(boxModelSection.element);
+
let computedStyleShowAllLabel = document.createElement("label");
computedStyleShowAllLabel.textContent = WI.UIString("Show All");
@@ -125,13 +132,6 @@
this.element.appendChild(this._propertiesSection.element);
this.element.appendChild(this._variablesSection.element);
-
- this._boxModelDiagramRow = new WI.BoxModelDetailsSectionRow;
-
- let boxModelGroup = new WI.DetailsSectionGroup([this._boxModelDiagramRow]);
- let boxModelSection = new WI.DetailsSection("computed-style-box-model", WI.UIString("Box Model"), [boxModelGroup]);
-
- this.element.appendChild(boxModelSection.element);
}
filterDidChange(filterBar)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
