Title: [248741] trunk/Source/WebKitLegacy/mac
- Revision
- 248741
- Author
- [email protected]
- Date
- 2019-08-15 13:21:05 -0700 (Thu, 15 Aug 2019)
Log Message
Yellow Lookup highlight gets stuck over Mail messages
https://bugs.webkit.org/show_bug.cgi?id=200778
<rdar://problem/53868514>
Reviewed by Wenson Hsieh.
* WebView/WebView.mm:
(-[WebView _showDictionaryLookupPopup:]):
Add a dismissal callback so that when Reveal hides the panel, it also
dismisses the yellow indicator. This matches the behavior in modern WebKit.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (248740 => 248741)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2019-08-15 20:13:14 UTC (rev 248740)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2019-08-15 20:21:05 UTC (rev 248741)
@@ -1,3 +1,16 @@
+2019-08-15 Tim Horton <[email protected]>
+
+ Yellow Lookup highlight gets stuck over Mail messages
+ https://bugs.webkit.org/show_bug.cgi?id=200778
+ <rdar://problem/53868514>
+
+ Reviewed by Wenson Hsieh.
+
+ * WebView/WebView.mm:
+ (-[WebView _showDictionaryLookupPopup:]):
+ Add a dismissal callback so that when Reveal hides the panel, it also
+ dismisses the yellow indicator. This matches the behavior in modern WebKit.
+
2019-08-15 Sihui Liu <[email protected]>
Some improvements on web storage
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (248740 => 248741)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2019-08-15 20:13:14 UTC (rev 248740)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2019-08-15 20:21:05 UTC (rev 248741)
@@ -246,6 +246,7 @@
#import <wtf/SetForScope.h>
#import <wtf/SoftLinking.h>
#import <wtf/StdLibExtras.h>
+#import <wtf/WeakObjCPtr.h>
#import <wtf/WorkQueue.h>
#import <wtf/spi/darwin/dyldSPI.h>
@@ -9507,6 +9508,8 @@
[self _setTextIndicator:textIndicator withLifetime:TextIndicatorWindowLifetime::Permanent];
}, [self](FloatRect rectInRootViewCoordinates) {
return [self _convertRectFromRootView:rectInRootViewCoordinates];
+ }, [weakSelf = WeakObjCPtr<WebView>(self)]() {
+ [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut];
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
