Title: [248757] trunk/Source/WebInspectorUI
- Revision
- 248757
- Author
- [email protected]
- Date
- 2019-08-15 18:58:38 -0700 (Thu, 15 Aug 2019)
Log Message
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._resource.initiatorSourceCodeLocation')
https://bugs.webkit.org/show_bug.cgi?id=200798
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WI.ResourceDetailsSidebarPanel.prototype.set resource):
(WI.ResourceDetailsSidebarPanel.prototype.layout):
Cancel the `Throttler` whenever the `_resource` is updated, as otherwise the `Throttler` may
fire later on with an unset `_resource`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248756 => 248757)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-16 01:54:20 UTC (rev 248756)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-16 01:58:38 UTC (rev 248757)
@@ -1,5 +1,18 @@
2019-08-15 Devin Rousso <[email protected]>
+ Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._resource.initiatorSourceCodeLocation')
+ https://bugs.webkit.org/show_bug.cgi?id=200798
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ResourceDetailsSidebarPanel.js:
+ (WI.ResourceDetailsSidebarPanel.prototype.set resource):
+ (WI.ResourceDetailsSidebarPanel.prototype.layout):
+ Cancel the `Throttler` whenever the `_resource` is updated, as otherwise the `Throttler` may
+ fire later on with an unset `_resource`.
+
+2019-08-15 Devin Rousso <[email protected]>
+
Web Inspector: Sources: provide a way to create an arbitrary Inspector Style Sheet
https://bugs.webkit.org/show_bug.cgi?id=200425
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js (248756 => 248757)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2019-08-16 01:54:20 UTC (rev 248756)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2019-08-16 01:58:38 UTC (rev 248757)
@@ -83,6 +83,7 @@
if (this._resource && this._needsToRemoveResourceEventListeners) {
this._resource.removeEventListener(null, null, this);
+ this._refreshRelatedResourcesSectionThrottler.cancel();
this._needsToRemoveResourceEventListeners = false;
}
@@ -211,7 +212,7 @@
this._refreshRequestHeaders();
this._refreshImageSizeSection();
this._refreshRequestDataSection();
- this._refreshRelatedResourcesSection();
+ this._refreshRelatedResourcesSectionThrottler.force();
}
sizeDidChange()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
