Title: [102912] trunk/Source/WebKit/qt
- Revision
- 102912
- Author
- [email protected]
- Date
- 2011-12-15 02:58:13 -0800 (Thu, 15 Dec 2011)
Log Message
[Qt] Remove unnecessary methods and members from DeviceOrientationClientQt
https://bugs.webkit.org/show_bug.cgi?id=74588
Patch by Alexander Færøy <[email protected]> on 2011-12-15
Reviewed by Simon Hausmann.
Remove the unused method changeDeviceOrientation() from
DeviceOrientationClientQt and remove the DeviceOrientationController
member since it is unused.
* WebCoreSupport/DeviceOrientationClientQt.cpp:
(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::setController):
* WebCoreSupport/DeviceOrientationClientQt.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (102911 => 102912)
--- trunk/Source/WebKit/qt/ChangeLog 2011-12-15 10:58:07 UTC (rev 102911)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-12-15 10:58:13 UTC (rev 102912)
@@ -1,3 +1,19 @@
+2011-12-15 Alexander Færøy <[email protected]>
+
+ [Qt] Remove unnecessary methods and members from DeviceOrientationClientQt
+ https://bugs.webkit.org/show_bug.cgi?id=74588
+
+ Reviewed by Simon Hausmann.
+
+ Remove the unused method changeDeviceOrientation() from
+ DeviceOrientationClientQt and remove the DeviceOrientationController
+ member since it is unused.
+
+ * WebCoreSupport/DeviceOrientationClientQt.cpp:
+ (WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
+ (WebCore::DeviceOrientationClientQt::setController):
+ * WebCoreSupport/DeviceOrientationClientQt.h:
+
2011-12-14 Jing Zhao <[email protected]>
Opening two popup menus by dispatchEvent() makes problems.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp (102911 => 102912)
--- trunk/Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp 2011-12-15 10:58:07 UTC (rev 102911)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp 2011-12-15 10:58:13 UTC (rev 102912)
@@ -19,15 +19,12 @@
*/
#include "config.h"
#include "DeviceOrientationClientQt.h"
-
-#include "DeviceOrientationController.h"
#include "DeviceOrientationProviderQt.h"
namespace WebCore {
DeviceOrientationClientQt::DeviceOrientationClientQt()
- : m_controller(0)
- , m_provider(new DeviceOrientationProviderQt())
+ : m_provider(new DeviceOrientationProviderQt)
{
}
@@ -38,7 +35,7 @@
void DeviceOrientationClientQt::setController(DeviceOrientationController* controller)
{
- m_controller = controller;
+ m_provider->setController(controller);
}
void DeviceOrientationClientQt::startUpdating()
@@ -61,12 +58,4 @@
delete this;
}
-void DeviceOrientationClientQt::changeDeviceOrientation(DeviceOrientation* orientation)
-{
- if (!m_controller)
- return;
-
- m_controller->didChangeDeviceOrientation(orientation);
-}
-
} // namespace WebCore
Modified: trunk/Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.h (102911 => 102912)
--- trunk/Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.h 2011-12-15 10:58:07 UTC (rev 102911)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.h 2011-12-15 10:58:13 UTC (rev 102912)
@@ -37,10 +37,8 @@
virtual void stopUpdating();
virtual DeviceOrientation* lastOrientation() const;
virtual void deviceOrientationControllerDestroyed();
- virtual void changeDeviceOrientation(DeviceOrientation*);
private:
- DeviceOrientationController* m_controller;
DeviceOrientationProviderQt* m_provider;
};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
