Title: [102914] trunk/Tools
- Revision
- 102914
- Author
- [email protected]
- Date
- 2011-12-15 03:44:03 -0800 (Thu, 15 Dec 2011)
Log Message
[chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
https://bugs.webkit.org/show_bug.cgi?id=74586
Patch by Shinya Kawanaka <[email protected]> on 2011-12-15
Reviewed by Hajime Morita.
No new tests. Covered by existing tests.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestCheckingOfText):
Returns immediately if text is empty.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (102913 => 102914)
--- trunk/Tools/ChangeLog 2011-12-15 11:21:48 UTC (rev 102913)
+++ trunk/Tools/ChangeLog 2011-12-15 11:44:03 UTC (rev 102914)
@@ -1,3 +1,16 @@
+2011-12-15 Shinya Kawanaka <[email protected]>
+
+ [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
+ https://bugs.webkit.org/show_bug.cgi?id=74586
+
+ Reviewed by Hajime Morita.
+
+ No new tests. Covered by existing tests.
+
+ * DumpRenderTree/chromium/WebViewHost.cpp:
+ (WebViewHost::requestCheckingOfText):
+ Returns immediately if text is empty.
+
2011-12-15 Alexander Færøy <[email protected]>
[Qt] QtWebKit fails to build on Mac OS X after r102776
Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (102913 => 102914)
--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2011-12-15 11:21:48 UTC (rev 102913)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2011-12-15 11:44:03 UTC (rev 102914)
@@ -436,6 +436,12 @@
void WebViewHost::requestCheckingOfText(const WebString& text, WebTextCheckingCompletion* completion)
{
+ if (text.isEmpty()) {
+ if (completion)
+ completion->didFinishCheckingText(Vector<WebTextCheckingResult>());
+ return;
+ }
+
m_lastRequestedTextCheckingCompletion = completion;
m_lastRequestedTextCheckString = text;
postDelayedTask(new HostMethodTask(this, &WebViewHost::finishLastTextCheck), 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
