Title: [248924] trunk/LayoutTests/imported/w3c
Revision
248924
Author
rn...@webkit.org
Date
2019-08-20 17:10:02 -0700 (Tue, 20 Aug 2019)

Log Message

Revert the unintended test change in r248914.

* web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (248923 => 248924)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-08-20 23:47:03 UTC (rev 248923)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-08-21 00:10:02 UTC (rev 248924)
@@ -1,3 +1,9 @@
+2019-08-20  Ryosuke Niwa  <rn...@webkit.org>
+
+        Revert the unintended test change in r248914.
+
+        * web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html:
+
 2019-08-14  Alexey Shvayka  <shvaikal...@gmail.com>
 
         Error thrown during "acceptNode" lookup is overridden

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html (248923 => 248924)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html	2019-08-20 23:47:03 UTC (rev 248923)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html	2019-08-21 00:10:02 UTC (rev 248924)
@@ -7,8 +7,8 @@
 <script src=""
 <div id="log"></div>
 <form id="f1">
-  <input type="radio" id="r1" name="ra">
-  <keygen id="kg" name="key"></keygen> <!-- we test that it does *not* appear in form.elements -->
+  <input type="radio" id="r1">
+  <keygen id="kg" name="key"></keygen>
 </form>
 <form id="f2">
   <table>
@@ -39,7 +39,7 @@
 
 //length
 test(function () {
-  assert_equals(coll1.length, 1, "The length attribute is incorrect.");
+  assert_equals(coll1.length, 2, "The length attribute is incorrect.");
   assert_equals(coll2.length, 4, "The length attribute is incorrect.");
 }, "The length attribute must return the number of elements in the form");
 
@@ -83,22 +83,17 @@
 }, "The namedItem(name) must return null if there is no matched element");
 
 test(function () {
-  assert_equals(coll1.namedItem("r1"), document.getElementById("r1"), "Controls can be named by 'id' attribute.");
-  assert_equals(coll1.namedItem("ra"), document.getElementById("r1"), "Controls can be named by 'name' attribute.");
+  assert_equals(coll1.namedItem("kg"), document.getElementById("kg"), "Controls can be named by 'id' attribute.");
+  assert_equals(coll1.namedItem("key"), document.getElementById("kg"), "Controls can be named by 'name' attribute.");
 }, "Controls can be indexed by id or name attribute");
 
 test(function () {
-  assert_equals(coll1.namedItem("kg"), null, "Keygen does not show up when queried by id.");
-  assert_equals(coll1.namedItem("key"), null, "Keygen does not show up when queried by name.");
-}, "Keygen controls do not show up at all");
-
-test(function () {
   assert_equals(coll2.namedItem("btn").length, 2, "The length attribute should be 2.");
 }, "The namedItem(name) must return the items with id or name attribute");
 
 //various controls in fieldset and form
 var containers = ["form", "fieldset"],
-    controls = ["button", "fieldset", "input", "object", "output", "select", "textarea"];
+    controls = ["button", "fieldset", "input", "keygen", "object", "output", "select", "textarea"];
 for (var m = 0; m < containers.length; m++) {
   test(function () {
     var container = document.createElement(containers[m]);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to