Title: [248931] trunk/Source/WebCore
- Revision
- 248931
- Author
- rn...@webkit.org
- Date
- 2019-08-20 18:39:54 -0700 (Tue, 20 Aug 2019)
Log Message
Remove MathMLElement::defaultTabIndex()
https://bugs.webkit.org/show_bug.cgi?id=200944
Reviewed by Frédéric Wang.
Removed MathMLElement::defaultTabIndex since it doesn't have any observable effect since
MathMLElement doesn't expose tabIndex IDL attribute, and sequential (tab key) focus navigation
checks MathMLElement::isKeyboardFocusable, which doesn't rely on defaultTabIndex, anyway.
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::defaultTabIndex const): Deleted.
* mathml/MathMLElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248930 => 248931)
--- trunk/Source/WebCore/ChangeLog 2019-08-21 01:36:41 UTC (rev 248930)
+++ trunk/Source/WebCore/ChangeLog 2019-08-21 01:39:54 UTC (rev 248931)
@@ -1,3 +1,18 @@
+2019-08-20 Ryosuke Niwa <rn...@webkit.org>
+
+ Remove MathMLElement::defaultTabIndex()
+ https://bugs.webkit.org/show_bug.cgi?id=200944
+
+ Reviewed by Frédéric Wang.
+
+ Removed MathMLElement::defaultTabIndex since it doesn't have any observable effect since
+ MathMLElement doesn't expose tabIndex IDL attribute, and sequential (tab key) focus navigation
+ checks MathMLElement::isKeyboardFocusable, which doesn't rely on defaultTabIndex, anyway.
+
+ * mathml/MathMLElement.cpp:
+ (WebCore::MathMLElement::defaultTabIndex const): Deleted.
+ * mathml/MathMLElement.h:
+
2019-08-20 Devin Rousso <drou...@apple.com>
Web Inspector: Implement `queryHolders` Command Line API
Modified: trunk/Source/WebCore/mathml/MathMLElement.cpp (248930 => 248931)
--- trunk/Source/WebCore/mathml/MathMLElement.cpp 2019-08-21 01:36:41 UTC (rev 248930)
+++ trunk/Source/WebCore/mathml/MathMLElement.cpp 2019-08-21 01:39:54 UTC (rev 248931)
@@ -221,12 +221,6 @@
return isLink() || StyledElement::supportsFocus();
}
-int MathMLElement::defaultTabIndex() const
-{
- // FIXME: This seems wrong.
- return 0;
}
-}
-
#endif // ENABLE(MATHML)
Modified: trunk/Source/WebCore/mathml/MathMLElement.h (248930 => 248931)
--- trunk/Source/WebCore/mathml/MathMLElement.h 2019-08-21 01:36:41 UTC (rev 248930)
+++ trunk/Source/WebCore/mathml/MathMLElement.h 2019-08-21 01:39:54 UTC (rev 248931)
@@ -108,7 +108,6 @@
bool isMouseFocusable() const final;
bool isURLAttribute(const Attribute&) const final;
bool supportsFocus() const final;
- int defaultTabIndex() const final;
};
inline bool Node::hasTagName(const MathMLQualifiedName& name) const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
