Title: [248944] trunk/Source/WebCore
- Revision
- 248944
- Author
- commit-qu...@webkit.org
- Date
- 2019-08-21 09:52:45 -0700 (Wed, 21 Aug 2019)
Log Message
REGRESSION: naver.com - Multiple taps are required to open email
https://bugs.webkit.org/show_bug.cgi?id=200979
<rdar://problem/54295239>
Patch by Antoine Quint <grao...@apple.com> on 2019-08-21
Reviewed by Dean Jackson.
The "click" events on subjects in the message list are prevented by preventDefault() being called from a "mouseup" event listener.
This shouldn't actually happen, but due to how simulated mouse events are implemented, there is no current distinction between
"touchend" and "mouseup" events. It is safe however to opt mail.naver.com out of simulated mouse events altogether.
* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (248943 => 248944)
--- trunk/Source/WebCore/ChangeLog 2019-08-21 16:50:14 UTC (rev 248943)
+++ trunk/Source/WebCore/ChangeLog 2019-08-21 16:52:45 UTC (rev 248944)
@@ -1,3 +1,18 @@
+2019-08-21 Antoine Quint <grao...@apple.com>
+
+ REGRESSION: naver.com - Multiple taps are required to open email
+ https://bugs.webkit.org/show_bug.cgi?id=200979
+ <rdar://problem/54295239>
+
+ Reviewed by Dean Jackson.
+
+ The "click" events on subjects in the message list are prevented by preventDefault() being called from a "mouseup" event listener.
+ This shouldn't actually happen, but due to how simulated mouse events are implemented, there is no current distinction between
+ "touchend" and "mouseup" events. It is safe however to opt mail.naver.com out of simulated mouse events altogether.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
2019-08-21 Devin Rousso <drou...@apple.com>
Web Inspector: Page: re-add enable/disable after r248454
Modified: trunk/Source/WebCore/page/Quirks.cpp (248943 => 248944)
--- trunk/Source/WebCore/page/Quirks.cpp 2019-08-21 16:50:14 UTC (rev 248943)
+++ trunk/Source/WebCore/page/Quirks.cpp 2019-08-21 16:52:45 UTC (rev 248944)
@@ -327,6 +327,9 @@
// Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
return false;
+ // Disable the quirk for mail.naver.com subdomain to be able to tap on mail subjects.
+ if (equalLettersIgnoringASCIICase(host, "mail.naver.com"))
+ return false;
// Disable the quirk on the mobile site.
// FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
if (equalLettersIgnoringASCIICase(host, "m.naver.com"))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
