Title: [248976] trunk/Tools
- Revision
- 248976
- Author
- aakash_j...@apple.com
- Date
- 2019-08-21 16:56:24 -0700 (Wed, 21 Aug 2019)
Log Message
[ews-build] view layout test results option should be displayed next to layout-test build step
https://bugs.webkit.org/show_bug.cgi?id=200048
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
(ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (248975 => 248976)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-08-21 23:51:34 UTC (rev 248975)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-08-21 23:56:24 UTC (rev 248976)
@@ -1489,9 +1489,18 @@
def resultsDownloadURL(self):
return self.zipFile.replace('public_html/', '/')
+ def getLastBuildStepByName(self, name):
+ for step in reversed(self.build.executedSteps):
+ if name in step.name:
+ return step
+ return None
+
def addCustomURLs(self):
- self.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
- self.addURL('download layout test results', self.resultsDownloadURL())
+ step = self.getLastBuildStepByName(RunWebKitTests.name)
+ if not step:
+ step = self
+ step.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
+ step.addURL('download layout test results', self.resultsDownloadURL())
def finished(self, result):
self.addCustomURLs()
Modified: trunk/Tools/ChangeLog (248975 => 248976)
--- trunk/Tools/ChangeLog 2019-08-21 23:51:34 UTC (rev 248975)
+++ trunk/Tools/ChangeLog 2019-08-21 23:56:24 UTC (rev 248976)
@@ -1,5 +1,16 @@
2019-08-21 Aakash Jain <aakash_j...@apple.com>
+ [ews-build] view layout test results option should be displayed next to layout-test build step
+ https://bugs.webkit.org/show_bug.cgi?id=200048
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
+ (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
+
+2019-08-21 Aakash Jain <aakash_j...@apple.com>
+
[ews] Fix capitalization in Found x new Test failure message
https://bugs.webkit.org/show_bug.cgi?id=201004
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
