Title: [248995] trunk/Tools
- Revision
- 248995
- Author
- [email protected]
- Date
- 2019-08-21 22:33:33 -0700 (Wed, 21 Aug 2019)
Log Message
results.webkit.org: Fix drawer style
https://bugs.webkit.org/show_bug.cgi?id=200988
Rubber-stamped by Aakash Jain.
* resultsdbpy/resultsdbpy/view/static/js/drawer.js:
(Drawer): Nothing in the drawer should be selectable.
(ConfigurationSelectors): Standardize text size, remove underscore from expanders.
* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
(.action:hover): Disable underline on 'links' which are actually actions
(.unselectable): Make a div unselectable.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (248994 => 248995)
--- trunk/Tools/ChangeLog 2019-08-22 02:55:32 UTC (rev 248994)
+++ trunk/Tools/ChangeLog 2019-08-22 05:33:33 UTC (rev 248995)
@@ -1,3 +1,19 @@
+2019-08-21 Jonathan Bedard <[email protected]>
+
+ results.webkit.org: Fix drawer style
+ https://bugs.webkit.org/show_bug.cgi?id=200988
+
+ Rubber-stamped by Aakash Jain.
+
+ * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
+ (Drawer): Nothing in the drawer should be selectable.
+ (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
+ * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
+ (.action:hover): Disable underline on 'links' which are actually actions
+ (.unselectable): Make a div unselectable.
+ * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+ (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
+
2019-08-21 Fujii Hironori <[email protected]>
[Win][MiniBrowser] Add a progress indicator to the main window
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js (248994 => 248995)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js 2019-08-22 02:55:32 UTC (rev 248994)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js 2019-08-22 05:33:33 UTC (rev 248995)
@@ -59,7 +59,7 @@
}
});
- return `<div class="drawer left under-topbar-with-actions" ref="${drawerRef}">
+ return `<div class="drawer left under-topbar-with-actions unselectable" ref="${drawerRef}">
${controls.map(control => {
return `<div class="list">
<div class="item">${control}</div>
@@ -226,7 +226,7 @@
}
});
- DOM.inject(element, `<a style="cursor: pointer;" class="text medium" ref="${expander}">+</a>
+ DOM.inject(element, `<a class="link-button text medium" ref="${expander}">+</a>
${details.name} <br>
${options.map(option => {
let isChecked = false;
@@ -275,7 +275,7 @@
ref.setState(configurations);
});
- return `<div ref="${ref}"></div>`;
+ return `<div style="font-size: var(--smallSize);" ref="${ref}"></div>`;
}).join('')
}
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (248994 => 248995)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-22 02:55:32 UTC (rev 248994)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-22 05:33:33 UTC (rev 248995)
@@ -194,6 +194,11 @@
text-decoration: underline;
}
+.link-button:hover {
+ text-decoration: none;
+ cursor: pointer;
+}
+
.divider, hr {
margin-block-start: 0.5em;
margin-block-end: 0.5em;
@@ -2555,3 +2560,9 @@
.progress-bar-container .progress-bar.error {
background: var(--orange);
}
+
+.unselectable {
+ -webkit-touch-callout: none;
+ -webkit-user-select: none;
+ user-select: none;
+}
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (248994 => 248995)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-22 02:55:32 UTC (rev 248994)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-22 05:33:33 UTC (rev 248995)
@@ -535,7 +535,7 @@
})
}));
return {
- header: Timeline.ExpandableHeaderComponent(`<a href="" ref="${ref}">+</a>` + mainLabel, subLabels, composer),
+ header: Timeline.ExpandableHeaderComponent(`<a class="link-button" href="" ref="${ref}">+</a>` + mainLabel, subLabels, composer),
series: Timeline.ExpandableSeriesComponent(mainSeries, subSerieses, composer),
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
