Title: [248999] trunk/Source/WebKit
- Revision
- 248999
- Author
- [email protected]
- Date
- 2019-08-22 02:40:25 -0700 (Thu, 22 Aug 2019)
Log Message
[SOUP] NetworkProcessSoup does not initialize CacheOptions correctly
https://bugs.webkit.org/show_bug.cgi?id=200886
Reviewed by Philippe Normand.
r247567 wrongly initializes CacheOptions in a local variable that is never used
instead of using NetworkProcess's member variable, that is later used by the
NetworkSession to initialize the cache.
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (248998 => 248999)
--- trunk/Source/WebKit/ChangeLog 2019-08-22 09:12:33 UTC (rev 248998)
+++ trunk/Source/WebKit/ChangeLog 2019-08-22 09:40:25 UTC (rev 248999)
@@ -1,3 +1,17 @@
+2019-08-22 Claudio Saavedra <[email protected]>
+
+ [SOUP] NetworkProcessSoup does not initialize CacheOptions correctly
+ https://bugs.webkit.org/show_bug.cgi?id=200886
+
+ Reviewed by Philippe Normand.
+
+ r247567 wrongly initializes CacheOptions in a local variable that is never used
+ instead of using NetworkProcess's member variable, that is later used by the
+ NetworkSession to initialize the cache.
+
+ * NetworkProcess/soup/NetworkProcessSoup.cpp:
+ (WebKit::NetworkProcess::platformInitializeNetworkProcess):
+
2019-08-21 Tim Horton <[email protected]>
[Mail] Tapping top of message scrolls back to copied text instead of top of the message
Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp (248998 => 248999)
--- trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp 2019-08-22 09:12:33 UTC (rev 248998)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp 2019-08-22 09:40:25 UTC (rev 248999)
@@ -117,10 +117,10 @@
SoupNetworkSession::clearOldSoupCache(FileSystem::directoryName(m_diskCacheDirectory));
- OptionSet<NetworkCache::CacheOption> cacheOptions { NetworkCache::CacheOption::RegisterNotify };
+ m_cacheOptions = { NetworkCache::CacheOption::RegisterNotify };
#if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
if (parameters.shouldEnableNetworkCacheSpeculativeRevalidation)
- cacheOptions.add(NetworkCache::CacheOption::SpeculativeRevalidation);
+ m_cacheOptions.add(NetworkCache::CacheOption::SpeculativeRevalidation);
#endif
supplement<WebCookieManager>()->setHTTPCookieAcceptPolicy(parameters.cookieAcceptPolicy, OptionalCallbackID());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
