Title: [249067] trunk/Tools
- Revision
- 249067
- Author
- [email protected]
- Date
- 2019-08-23 14:06:02 -0700 (Fri, 23 Aug 2019)
Log Message
Increase log level for watchlist result
https://bugs.webkit.org/show_bug.cgi?id=201081
Reviewed by Jonathan Bedard.
* Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
* Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (249066 => 249067)
--- trunk/Tools/ChangeLog 2019-08-23 20:58:49 UTC (rev 249066)
+++ trunk/Tools/ChangeLog 2019-08-23 21:06:02 UTC (rev 249067)
@@ -1,3 +1,14 @@
+2019-08-23 Aakash Jain <[email protected]>
+
+ Increase log level for watchlist result
+ https://bugs.webkit.org/show_bug.cgi?id=201081
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
+ * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
+ * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
+
2019-08-23 Chris Dumez <[email protected]>
[geolocation] Rename interfaces and remove [NoInterfaceObject]
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py (249066 => 249067)
--- trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py 2019-08-23 20:58:49 UTC (rev 249066)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py 2019-08-23 21:06:02 UTC (rev 249067)
@@ -48,7 +48,11 @@
Message1.
Message2.
---- End comment ---\n\n"""
+--- End comment ---\n
+Result of watchlist: cc "[email protected], [email protected], [email protected]" messages "Message1.
+
+Message2."
+"""
self.assert_execute_outputs(ApplyWatchListLocal(), ['50002'], expected_logs=expected_logs)
def test_args_parsing_with_two_bugs(self):
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py (249066 => 249067)
--- trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py 2019-08-23 20:58:49 UTC (rev 249066)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py 2019-08-23 21:06:02 UTC (rev 249067)
@@ -63,8 +63,6 @@
if bug_id:
if cc_emails or comment_text:
self._tool.bugs.post_comment_to_bug(bug_id, comment_text, cc_emails)
- log_result = _log.debug
else:
_log.info('No bug was updated because no id was given.')
- log_result = _log.info
- log_result('Result of watchlist: cc "%s" messages "%s"' % (', '.join(cc_emails), comment_text))
+ _log.info('Result of watchlist: cc "{}" messages "{}"'.format(', '.join(cc_emails), comment_text))
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py (249066 => 249067)
--- trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py 2019-08-23 20:58:49 UTC (rev 249066)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py 2019-08-23 21:06:02 UTC (rev 249067)
@@ -47,5 +47,6 @@
Message2.
--- End comment ---
+Result of watchlist: cc "[email protected]" messages "Message2."
"""
capture.assert_outputs(self, step.run, [state], expected_logs=expected_logs)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
