Title: [249076] trunk/Source/WebCore
- Revision
- 249076
- Author
- [email protected]
- Date
- 2019-08-23 17:20:57 -0700 (Fri, 23 Aug 2019)
Log Message
REGRESSION (r248807): Objects stored in ElementRareData are leaked
https://bugs.webkit.org/show_bug.cgi?id=200954
Reviewed by David Kilzer.
NodeRareData didn't have a virtual destructor. As a result, member variables
of ElementRareData did not get destructed properly.
* dom/NodeRareData.cpp:
* dom/NodeRareData.h:
(WebCore::NodeRareData::~NodeRareData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249075 => 249076)
--- trunk/Source/WebCore/ChangeLog 2019-08-23 23:08:06 UTC (rev 249075)
+++ trunk/Source/WebCore/ChangeLog 2019-08-24 00:20:57 UTC (rev 249076)
@@ -1,3 +1,17 @@
+2019-08-23 Ryosuke Niwa <[email protected]>
+
+ REGRESSION (r248807): Objects stored in ElementRareData are leaked
+ https://bugs.webkit.org/show_bug.cgi?id=200954
+
+ Reviewed by David Kilzer.
+
+ NodeRareData didn't have a virtual destructor. As a result, member variables
+ of ElementRareData did not get destructed properly.
+
+ * dom/NodeRareData.cpp:
+ * dom/NodeRareData.h:
+ (WebCore::NodeRareData::~NodeRareData):
+
2019-08-23 Wenson Hsieh <[email protected]>
[iOS] [WebKit2] Tapping on the “I’m” text suggestion after typing “i’” does nothing
Modified: trunk/Source/WebCore/dom/NodeRareData.cpp (249075 => 249076)
--- trunk/Source/WebCore/dom/NodeRareData.cpp 2019-08-23 23:08:06 UTC (rev 249075)
+++ trunk/Source/WebCore/dom/NodeRareData.cpp 2019-08-24 00:20:57 UTC (rev 249076)
@@ -36,8 +36,8 @@
namespace WebCore {
struct SameSizeAsNodeRareData {
- unsigned m_bitfields : 20;
- void* m_pointer[2];
+ unsigned m_frameCount;
+ void* m_pointer[3];
};
COMPILE_ASSERT(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), NodeRareDataShouldStaySmall);
Modified: trunk/Source/WebCore/dom/NodeRareData.h (249075 => 249076)
--- trunk/Source/WebCore/dom/NodeRareData.h 2019-08-23 23:08:06 UTC (rev 249075)
+++ trunk/Source/WebCore/dom/NodeRareData.h 2019-08-24 00:20:57 UTC (rev 249076)
@@ -273,6 +273,9 @@
NodeRareData()
{ }
+ virtual ~NodeRareData()
+ { }
+
void clearNodeLists() { m_nodeLists = nullptr; }
NodeListsNodeData* nodeLists() const { return m_nodeLists.get(); }
NodeListsNodeData& ensureNodeLists()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
