Title: [249086] trunk/Source/WebCore
- Revision
- 249086
- Author
- [email protected]
- Date
- 2019-08-24 06:36:29 -0700 (Sat, 24 Aug 2019)
Log Message
[LFC][TFC] Add section renderers to the layout tree (THEAD/TBODY/TFOOT)
https://bugs.webkit.org/show_bug.cgi?id=201114
<rdar://problem/54664992>
Reviewed by Antti Koivisto.
Section renderers (THEAD/TBODY/TFOOT) are direct children of the RenderTable. Let's include them in the layout tree as well.
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createTableStructure):
(WebCore::Layout::outputInlineRuns):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249085 => 249086)
--- trunk/Source/WebCore/ChangeLog 2019-08-24 13:34:50 UTC (rev 249085)
+++ trunk/Source/WebCore/ChangeLog 2019-08-24 13:36:29 UTC (rev 249086)
@@ -1,5 +1,19 @@
2019-08-24 Zalan Bujtas <[email protected]>
+ [LFC][TFC] Add section renderers to the layout tree (THEAD/TBODY/TFOOT)
+ https://bugs.webkit.org/show_bug.cgi?id=201114
+ <rdar://problem/54664992>
+
+ Reviewed by Antti Koivisto.
+
+ Section renderers (THEAD/TBODY/TFOOT) are direct children of the RenderTable. Let's include them in the layout tree as well.
+
+ * layout/layouttree/LayoutTreeBuilder.cpp:
+ (WebCore::Layout::TreeBuilder::createTableStructure):
+ (WebCore::Layout::outputInlineRuns):
+
+2019-08-24 Zalan Bujtas <[email protected]>
+
[LFC] Box::isAnonymous() can not rely on the lack of ElementType.
https://bugs.webkit.org/show_bug.cgi?id=201106
<rdar://problem/54660287>
Modified: trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp (249085 => 249086)
--- trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp 2019-08-24 13:34:50 UTC (rev 249085)
+++ trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp 2019-08-24 13:36:29 UTC (rev 249086)
@@ -215,9 +215,14 @@
auto tableBox = makeUnique<Container>(Box::ElementAttributes { Box::ElementType::TableBox }, RenderStyle::clone(tableRenderer.style()));
appendChild(tableWrapperBox, *tableBox);
- while (tableChild) {
- TreeBuilder::createSubTree(downcast<RenderElement>(*tableChild), *tableBox);
- tableChild = tableChild->nextSibling();
+ auto* sectionRenderer = tableChild;
+ while (sectionRenderer) {
+ auto sectionBox = createLayoutBox(tableRenderer, *sectionRenderer);
+ appendChild(*tableBox, *sectionBox);
+ auto& sectionContainer = downcast<Container>(*sectionBox);
+ TreeBuilder::createSubTree(downcast<RenderElement>(*sectionRenderer), sectionContainer);
+ sectionBox.release();
+ sectionRenderer = sectionRenderer->nextSibling();
}
// Temporary
tableBox.release();
@@ -259,7 +264,7 @@
stream << " ";
if (inlineRun->textContext())
stream << "inline text box";
- else
+ else
stream << "inline box";
stream << " at (" << inlineRun->logicalLeft() << "," << inlineRun->logicalTop() << ") size " << inlineRun->logicalWidth() << "x" << inlineRun->logicalHeight();
if (inlineRun->textContext())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
