Title: [249102] trunk/Tools
- Revision
- 249102
- Author
- [email protected]
- Date
- 2019-08-26 10:21:28 -0700 (Mon, 26 Aug 2019)
Log Message
run-webkit-tests: Cap the number of automatically booted simulators at 12
https://bugs.webkit.org/show_bug.cgi?id=201139
Reviewed by Aakash Jain.
To make local development with simulators more pleasant, machines should
never automatically boot more than 12 simulators.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.max_supported_simulators):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (249101 => 249102)
--- trunk/Tools/ChangeLog 2019-08-26 17:12:43 UTC (rev 249101)
+++ trunk/Tools/ChangeLog 2019-08-26 17:21:28 UTC (rev 249102)
@@ -1,3 +1,16 @@
+2019-08-26 Jonathan Bedard <[email protected]>
+
+ run-webkit-tests: Cap the number of automatically booted simulators at 12
+ https://bugs.webkit.org/show_bug.cgi?id=201139
+
+ Reviewed by Aakash Jain.
+
+ To make local development with simulators more pleasant, machines should
+ never automatically boot more than 12 simulators.
+
+ * Scripts/webkitpy/xcode/simulated_device.py:
+ (SimulatedDeviceManager.max_supported_simulators):
+
2019-08-26 Aakash Jain <[email protected]>
[ews] Add EWS queue for applying watchlist
Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (249101 => 249102)
--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2019-08-26 17:12:43 UTC (rev 249101)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py 2019-08-26 17:21:28 UTC (rev 249102)
@@ -67,6 +67,10 @@
MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE = 6 * (1024 ** 3) # 6GB a simulator.
PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE = 125
+ # Testing on iMac Pros has indicated that more than 12 simulators, even if we seem to have enough resources for them,
+ # results in diminishing returns.
+ MAX_NUMBER_OF_SIMULATORS = 12
+
xcrun = '/usr/bin/xcrun'
simulator_device_path = '~/Library/Developer/CoreSimulator/Devices'
simulator_bundle_id = 'com.apple.iphonesimulator'
@@ -417,7 +421,11 @@
except (ValueError, ScriptError):
return 0
- max_supported_simulators_for_hardware = min(host.executive.cpu_count() / 2, host.platform.total_bytes_memory() // SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE)
+ max_supported_simulators_for_hardware = min(
+ host.executive.cpu_count() // 2,
+ host.platform.total_bytes_memory() // SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE,
+ SimulatedDeviceManager.MAX_NUMBER_OF_SIMULATORS,
+ )
max_supported_simulators_locally = (system_process_count_limit - current_process_count) // SimulatedDeviceManager.PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE
if (max_supported_simulators_locally < max_supported_simulators_for_hardware):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
