Modified: trunk/LayoutTests/ChangeLog (249121 => 249122)
--- trunk/LayoutTests/ChangeLog 2019-08-26 22:31:59 UTC (rev 249121)
+++ trunk/LayoutTests/ChangeLog 2019-08-26 23:01:47 UTC (rev 249122)
@@ -1,3 +1,12 @@
+2019-08-26 Devin Rousso <[email protected]>
+
+ Unreviewed, fix test failure after r200971
+
+ * inspector/timeline/line-column-expected.txt:
+
+ * inspector/debugger/tail-deleted-frames-this-value.html:
+ Add messages to all `InspectorTest.assert` so we can know which one is firing on the bots.
+
2019-08-26 Wenson Hsieh <[email protected]>
Unreviewed, unmark two datalist tests as timing out on iOS 13 after r249112
Modified: trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html (249121 => 249122)
--- trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html 2019-08-26 22:31:59 UTC (rev 249121)
+++ trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html 2019-08-26 23:01:47 UTC (rev 249122)
@@ -42,7 +42,7 @@
let targetData = WI.debuggerManager.dataForTarget(WI.debuggerManager.activeCallFrame.target);
let callFrames = targetData.callFrames;
- InspectorTest.assert(callFrames.length >= expectedFrames.length);
+ InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have ${expectedFrames.length} frames.`);
// Resolve a thisObject preview on each of the CallFrames.
let promises = [];
@@ -60,12 +60,12 @@
let callFrame = callFrames[i];
let expectedFrame = expectedFrames[i];
InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
- InspectorTest.assert(callFrame.functionName === expectedFrame.functionName);
- InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted);
+ InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}'.`);
+ InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}.`);
let thisObject = callFrame.thisObject;
let properties = thisObject.preview.propertyPreviews;
- InspectorTest.assert(properties.length === 1);
+ InspectorTest.assert(properties.length === 1, "Should hvae one property.");
let prop = properties[0];
InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);
InspectorTest.assert('' + expectedFrame.thisValue[1] === prop.value, `'this' value object should have expected property value: ${expectedFrame.thisValue[1]}`);
Modified: trunk/LayoutTests/inspector/timeline/line-column-expected.txt (249121 => 249122)
--- trunk/LayoutTests/inspector/timeline/line-column-expected.txt 2019-08-26 22:31:59 UTC (rev 249121)
+++ trunk/LayoutTests/inspector/timeline/line-column-expected.txt 2019-08-26 23:01:47 UTC (rev 249122)
@@ -45,7 +45,7 @@
"functionName": "",
"url": "",
"scriptId": "<filtered>",
- "lineNumber": 141,
+ "lineNumber": 144,
"columnNumber": 97
}
],
@@ -107,7 +107,7 @@
"functionName": "",
"url": "",
"scriptId": "<filtered>",
- "lineNumber": 141,
+ "lineNumber": 144,
"columnNumber": 97
}
],
@@ -160,7 +160,7 @@
"functionName": "",
"url": "",
"scriptId": "<filtered>",
- "lineNumber": 141,
+ "lineNumber": 144,
"columnNumber": 97
}
],
@@ -220,7 +220,7 @@
"functionName": "",
"url": "",
"scriptId": "<filtered>",
- "lineNumber": 141,
+ "lineNumber": 144,
"columnNumber": 97
}
],
