Title: [249127] trunk/LayoutTests
- Revision
- 249127
- Author
- [email protected]
- Date
- 2019-08-26 17:48:14 -0700 (Mon, 26 Aug 2019)
Log Message
Unreviewed, add extra test failure logging after r200971
* inspector/debugger/tail-deleted-frames-this-value.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (249126 => 249127)
--- trunk/LayoutTests/ChangeLog 2019-08-27 00:20:31 UTC (rev 249126)
+++ trunk/LayoutTests/ChangeLog 2019-08-27 00:48:14 UTC (rev 249127)
@@ -1,3 +1,10 @@
+2019-08-26 Devin Rousso <[email protected]>
+
+ Unreviewed, add extra test failure logging after r200971
+
+ * inspector/debugger/tail-deleted-frames-this-value.html:
+ Also log the actual value (in addition to the expected one) in assertion messages.
+
2019-08-26 Wenson Hsieh <[email protected]>
Remove UIHelper.activateElementAtHumanSpeed
Modified: trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html (249126 => 249127)
--- trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html 2019-08-27 00:20:31 UTC (rev 249126)
+++ trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html 2019-08-27 00:48:14 UTC (rev 249127)
@@ -42,7 +42,7 @@
let targetData = WI.debuggerManager.dataForTarget(WI.debuggerManager.activeCallFrame.target);
let callFrames = targetData.callFrames;
- InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have ${expectedFrames.length} frames.`);
+ InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have at least ${expectedFrames.length} frames, but have ${callFrame.length} instead.`);
// Resolve a thisObject preview on each of the CallFrames.
let promises = [];
@@ -60,12 +60,12 @@
let callFrame = callFrames[i];
let expectedFrame = expectedFrames[i];
InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
- InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}'.`);
- InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}.`);
+ InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}', but have '${callFrame.functionName}' instead.`);
+ InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}', but have '${callFrame.isTailDeleted}' instead.`);
let thisObject = callFrame.thisObject;
let properties = thisObject.preview.propertyPreviews;
- InspectorTest.assert(properties.length === 1, "Should hvae one property.");
+ InspectorTest.assert(properties.length === 1, "Should have one property.");
let prop = properties[0];
InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);
InspectorTest.assert('' + expectedFrame.thisValue[1] === prop.value, `'this' value object should have expected property value: ${expectedFrame.thisValue[1]}`);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
