Title: [249130] trunk
- Revision
- 249130
- Author
- [email protected]
- Date
- 2019-08-26 20:19:06 -0700 (Mon, 26 Aug 2019)
Log Message
Change default value of window.open()'s url argument
https://bugs.webkit.org/show_bug.cgi?id=200882
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline WPT test now that it is passing.
* web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt:
Source/WebCore:
Update default URL parameter value for window.open() to be "" instead of "about:blank", as per:
- https://github.com/whatwg/html/issues/4762
This aligns our behavior with other Web browser engines.
No new tests, rebaselined existing test.
* page/DOMWindow.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (249129 => 249130)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-08-27 02:20:56 UTC (rev 249129)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-08-27 03:19:06 UTC (rev 249130)
@@ -1,5 +1,16 @@
2019-08-26 Chris Dumez <[email protected]>
+ Change default value of window.open()'s url argument
+ https://bugs.webkit.org/show_bug.cgi?id=200882
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline WPT test now that it is passing.
+
+ * web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt:
+
+2019-08-26 Chris Dumez <[email protected]>
+
Resync web-platform-tests/html/browsers/the-window-object from upstream
https://bugs.webkit.org/show_bug.cgi?id=201145
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt (249129 => 249130)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt 2019-08-27 02:20:56 UTC (rev 249129)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt 2019-08-27 03:19:06 UTC (rev 249130)
@@ -1,3 +1,3 @@
-FAIL window.open()'s url parameter default assert_unreached: Reached unreachable code
+PASS window.open()'s url parameter default
Modified: trunk/Source/WebCore/ChangeLog (249129 => 249130)
--- trunk/Source/WebCore/ChangeLog 2019-08-27 02:20:56 UTC (rev 249129)
+++ trunk/Source/WebCore/ChangeLog 2019-08-27 03:19:06 UTC (rev 249130)
@@ -1,3 +1,19 @@
+2019-08-26 Chris Dumez <[email protected]>
+
+ Change default value of window.open()'s url argument
+ https://bugs.webkit.org/show_bug.cgi?id=200882
+
+ Reviewed by Ryosuke Niwa.
+
+ Update default URL parameter value for window.open() to be "" instead of "about:blank", as per:
+ - https://github.com/whatwg/html/issues/4762
+
+ This aligns our behavior with other Web browser engines.
+
+ No new tests, rebaselined existing test.
+
+ * page/DOMWindow.idl:
+
2019-08-26 Devin Rousso <[email protected]>
Web Inspector: unify agent command error messages
Modified: trunk/Source/WebCore/page/DOMWindow.idl (249129 => 249130)
--- trunk/Source/WebCore/page/DOMWindow.idl 2019-08-27 02:20:56 UTC (rev 249129)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2019-08-27 03:19:06 UTC (rev 249130)
@@ -77,7 +77,7 @@
[DoNotCheckSecurityOnGetter, CustomSetter] attribute WindowProxy? opener;
[Replaceable, DoNotCheckSecurityOnGetter] readonly attribute WindowProxy? parent;
[CheckSecurityForNode] readonly attribute Element? frameElement;
- [CallWith=ActiveWindow&FirstWindow, MayThrowException] WindowProxy? open(optional USVString url = "" optional DOMString target = "_blank", optional [TreatNullAs=EmptyString] DOMString features = "");
+ [CallWith=ActiveWindow&FirstWindow, MayThrowException] WindowProxy? open(optional USVString url = "" optional DOMString target = "_blank", optional [TreatNullAs=EmptyString] DOMString features = "");
// The user agent.
readonly attribute Navigator navigator;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
