Title: [249134] trunk/Source/WebCore
- Revision
- 249134
- Author
- [email protected]
- Date
- 2019-08-27 00:38:41 -0700 (Tue, 27 Aug 2019)
Log Message
Make MediaStreamTrackPrivate RefCounted
https://bugs.webkit.org/show_bug.cgi?id=201040
Reviewed by Darin Adler.
MediaStreamTrackPrivate should not be ref/deref except from the main thread.
The only method called from a background thread is audioSamplesAvailable in which
it is unsafe to ref a MediaStreamTrackPrivate.
Make the track RefCounted will ensure that no ref/deref is made in background threads.
No observable change of behavior.
* platform/mediastream/MediaStreamTrackPrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249133 => 249134)
--- trunk/Source/WebCore/ChangeLog 2019-08-27 06:51:49 UTC (rev 249133)
+++ trunk/Source/WebCore/ChangeLog 2019-08-27 07:38:41 UTC (rev 249134)
@@ -1,3 +1,18 @@
+2019-08-27 Youenn Fablet <[email protected]>
+
+ Make MediaStreamTrackPrivate RefCounted
+ https://bugs.webkit.org/show_bug.cgi?id=201040
+
+ Reviewed by Darin Adler.
+
+ MediaStreamTrackPrivate should not be ref/deref except from the main thread.
+ The only method called from a background thread is audioSamplesAvailable in which
+ it is unsafe to ref a MediaStreamTrackPrivate.
+ Make the track RefCounted will ensure that no ref/deref is made in background threads.
+ No observable change of behavior.
+
+ * platform/mediastream/MediaStreamTrackPrivate.h:
+
2019-08-26 Yusuke Suzuki <[email protected]>
[WebCore] DataCue should not use gcProtect / gcUnprotect
Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h (249133 => 249134)
--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2019-08-27 06:51:49 UTC (rev 249133)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2019-08-27 07:38:41 UTC (rev 249134)
@@ -31,6 +31,7 @@
#include "RealtimeMediaSource.h"
#include <wtf/LoggerHelper.h>
+#include <wtf/RefCounted.h>
#include <wtf/WeakPtr.h>
namespace WebCore {
@@ -42,7 +43,7 @@
class WebAudioSourceProvider;
class MediaStreamTrackPrivate final
- : public ThreadSafeRefCounted<MediaStreamTrackPrivate, WTF::DestructionThread::Main>
+ : public RefCounted<MediaStreamTrackPrivate>
, public CanMakeWeakPtr<MediaStreamTrackPrivate, WeakPtrFactoryInitialization::Eager>
, public RealtimeMediaSource::Observer
#if !RELEASE_LOG_DISABLED
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
