Title: [249152] trunk/LayoutTests
Revision
249152
Author
wenson_hs...@apple.com
Date
2019-08-27 11:06:14 -0700 (Tue, 27 Aug 2019)

Log Message

fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html times out on iPad
https://bugs.webkit.org/show_bug.cgi?id=201182
<rdar://problem/54562829>

Reviewed by Tim Horton.

This test verifies that if the user taps outside of a scrollable container that is decelerating, the page will
observe a click event. This test currently behaves as expected on iPhone, but on iPad, the tap which is
intended to be outside the scrollable area ends up inside it, so a click event is never dispatched. Instead of
hard-coding the tap location, address this test failure by targetting a separate element outside of the
scrollable area.

* fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (249151 => 249152)


--- trunk/LayoutTests/ChangeLog	2019-08-27 18:01:31 UTC (rev 249151)
+++ trunk/LayoutTests/ChangeLog	2019-08-27 18:06:14 UTC (rev 249152)
@@ -1,3 +1,19 @@
+2019-08-27  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html times out on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=201182
+        <rdar://problem/54562829>
+
+        Reviewed by Tim Horton.
+
+        This test verifies that if the user taps outside of a scrollable container that is decelerating, the page will
+        observe a click event. This test currently behaves as expected on iPhone, but on iPad, the tap which is
+        intended to be outside the scrollable area ends up inside it, so a click event is never dispatched. Instead of
+        hard-coding the tap location, address this test failure by targetting a separate element outside of the
+        scrollable area.
+
+        * fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html:
+
 2019-08-26  Jer Noble  <jer.no...@apple.com>
 
         Removing fullscreen element in rAF() callback after requestFullscreen() can leave fullscreen in inconsistent state.

Modified: trunk/LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html (249151 => 249152)


--- trunk/LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html	2019-08-27 18:01:31 UTC (rev 249151)
+++ trunk/LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html	2019-08-27 18:06:14 UTC (rev 249152)
@@ -27,11 +27,18 @@
     padding: 20px;
     background: linear-gradient(to bottom, red 0%, green 50%, blue 100%);
 }
+
+#target {
+    width: 100%;
+    height: 50px;
+    margin-top: 1em;
+}
 </style>
 <body _onload_="runTest()">
     <div id="scroller">
         <div id="content"></div>
     </div>
+    <div id="target"></div>
     <p id="description"></p>
     <p id="console"></p>
 </body>
@@ -62,7 +69,7 @@
     reachedMinimumScrollPosition = true;
     testPassed(`scroller.scrollTop passed ${minimumExpectedScrollTop}`);
     removeEventListener("scroll", observeScrollEvent);
-    await UIHelper.activateAt(160, 350);
+    await UIHelper.activateElement(document.getElementById("target"));
     noteTestProgress();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to