Title: [249201] trunk/LayoutTests
- Revision
- 249201
- Author
- [email protected]
- Date
- 2019-08-28 09:28:27 -0700 (Wed, 28 Aug 2019)
Log Message
Flaky Test: fullscreen/full-screen-request-removed-with-raf.html
https://bugs.webkit.org/show_bug.cgi?id=201188
Reviewed by Alexey Proskuryakov.
* fullscreen/full-screen-request-removed-with-raf.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (249200 => 249201)
--- trunk/LayoutTests/ChangeLog 2019-08-28 15:45:20 UTC (rev 249200)
+++ trunk/LayoutTests/ChangeLog 2019-08-28 16:28:27 UTC (rev 249201)
@@ -1,3 +1,12 @@
+2019-08-28 Jer Noble <[email protected]>
+
+ Flaky Test: fullscreen/full-screen-request-removed-with-raf.html
+ https://bugs.webkit.org/show_bug.cgi?id=201188
+
+ Reviewed by Alexey Proskuryakov.
+
+ * fullscreen/full-screen-request-removed-with-raf.html:
+
2019-08-28 Carlos Garcia Campos <[email protected]>
Unable to enter text in https://eat.fi
Modified: trunk/LayoutTests/fullscreen/full-screen-request-removed-with-raf.html (249200 => 249201)
--- trunk/LayoutTests/fullscreen/full-screen-request-removed-with-raf.html 2019-08-28 15:45:20 UTC (rev 249200)
+++ trunk/LayoutTests/fullscreen/full-screen-request-removed-with-raf.html 2019-08-28 16:28:27 UTC (rev 249201)
@@ -4,9 +4,16 @@
window.addEventListener('load', (ev) => {
var target = document.querySelector('#target');
+ var didRemoveChild = false;
- document.addEventListener('webkitfullscreenchange', (ev) => {
- if (document.webkitCurrentFullScreenElement && !document.webkitCurrentFullScreenElement.ownerDocument)
+ document.addEventListener('webkitfullscreenchange', (ev) => {
+ if (!didRemoveChild) {
+ // The 'webkitfullscreenchange' event was fired before the rAF() timer. This is not a
+ // successful test, but not a failure either.
+ removeTarget();
+ consoleWrite("SUCCESS");
+
+ } else if (document.webkitCurrentFullScreenElement && !document.webkitCurrentFullScreenElement.ownerDocument)
consoleWrite("FAIL: document.webkitCurrentFullScreenElement.ownerDocument is NULL!");
else
consoleWrite("SUCCESS");
@@ -20,14 +27,20 @@
endTest();
}, {once: true});
+ function removeTarget()
+ {
+ if (didRemoveChild)
+ return;
+ consoleWrite("Removed child element.");
+ target.parentNode.removeChild(target);
+ didRemoveChild = true;
+ consoleWrite("");
+ }
+
function test()
{
target.webkitRequestFullScreen();
- window.requestAnimationFrame(() => {
- consoleWrite("Removed child element.");
- target.parentNode.removeChild(target);
- consoleWrite("");
- });
+ window.requestAnimationFrame(removeTarget);
}
runWithKeyDown(test);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
