Title: [249245] trunk/Tools
- Revision
- 249245
- Author
- [email protected]
- Date
- 2019-08-28 23:26:38 -0700 (Wed, 28 Aug 2019)
Log Message
[Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
https://bugs.webkit.org/show_bug.cgi?id=201215
Reviewed by Don Olmstead.
MiniBrowser crashed if it was going to go to a unreachable page
because WKPageCopyActiveURL returned a nullptr.
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(createString): Added null checking of the argument.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (249244 => 249245)
--- trunk/Tools/ChangeLog 2019-08-29 06:13:42 UTC (rev 249244)
+++ trunk/Tools/ChangeLog 2019-08-29 06:26:38 UTC (rev 249245)
@@ -1,3 +1,16 @@
+2019-08-28 Fujii Hironori <[email protected]>
+
+ [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
+ https://bugs.webkit.org/show_bug.cgi?id=201215
+
+ Reviewed by Don Olmstead.
+
+ MiniBrowser crashed if it was going to go to a unreachable page
+ because WKPageCopyActiveURL returned a nullptr.
+
+ * MiniBrowser/win/WebKitBrowserWindow.cpp:
+ (createString): Added null checking of the argument.
+
2019-08-28 Tim Horton <[email protected]>
Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
Modified: trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp (249244 => 249245)
--- trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2019-08-29 06:13:42 UTC (rev 249244)
+++ trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2019-08-29 06:26:38 UTC (rev 249245)
@@ -49,6 +49,8 @@
std::wstring createString(WKURLRef wkURL)
{
+ if (!wkURL)
+ return { };
WKRetainPtr<WKStringRef> url = ""
return createString(url.get());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
