Title: [249253] trunk/Source/WebCore
- Revision
- 249253
- Author
- [email protected]
- Date
- 2019-08-29 04:10:45 -0700 (Thu, 29 Aug 2019)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=200917
Do not call addHTTPOriginIfNeeded for window.open
window.open() always uses GET requests and addHTTPOriginIfNeeded
has no effect for GET, so do not call it.
Patch by Rob Buis <[email protected]> on 2019-08-29
Reviewed by Frédéric Wang.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249252 => 249253)
--- trunk/Source/WebCore/ChangeLog 2019-08-29 10:39:39 UTC (rev 249252)
+++ trunk/Source/WebCore/ChangeLog 2019-08-29 11:10:45 UTC (rev 249253)
@@ -1,3 +1,16 @@
+2019-08-29 Rob Buis <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=200917
+ Do not call addHTTPOriginIfNeeded for window.open
+
+ window.open() always uses GET requests and addHTTPOriginIfNeeded
+ has no effect for GET, so do not call it.
+
+ Reviewed by Frédéric Wang.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::createWindow):
+
2019-08-29 Carlos Garcia Campos <[email protected]>
WebSockets: first-party for cookies not set in handshake request when using platform APIs
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (249252 => 249253)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2019-08-29 10:39:39 UTC (rev 249252)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2019-08-29 11:10:45 UTC (rev 249253)
@@ -2357,7 +2357,6 @@
auto initiatedByMainFrame = activeFrame->isMainFrame() ? InitiatedByMainFrame::Yes : InitiatedByMainFrame::Unknown;
ResourceRequest resourceRequest { completedURL, referrer };
- FrameLoader::addHTTPOriginIfNeeded(resourceRequest, firstFrame.loader().outgoingOrigin());
FrameLoadRequest frameLoadRequest { *activeDocument, activeDocument->securityOrigin(), resourceRequest, frameName, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, AllowNavigationToInvalidURL::Yes, NewFrameOpenerPolicy::Allow, activeDocument->shouldOpenExternalURLsPolicyToPropagate(), initiatedByMainFrame };
// We pass the opener frame for the lookupFrame in case the active frame is different from
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
