Title: [102969] trunk/Source/WebCore
- Revision
- 102969
- Author
- [email protected]
- Date
- 2011-12-15 11:28:14 -0800 (Thu, 15 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=74631
HTMLMediaElement should not register for document activation callbacks as it doesn't use them
Reviewed by Eric Carlson.
No new tests. (No behavior change, pruning useless code)
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument):
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (102968 => 102969)
--- trunk/Source/WebCore/ChangeLog 2011-12-15 19:18:54 UTC (rev 102968)
+++ trunk/Source/WebCore/ChangeLog 2011-12-15 19:28:14 UTC (rev 102969)
@@ -1,3 +1,18 @@
+2011-12-15 Brady Eidson <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=74631
+ HTMLMediaElement should not register for document activation callbacks as it doesn't use them
+
+ Reviewed by Eric Carlson.
+
+ No new tests. (No behavior change, pruning useless code)
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement):
+ (WebCore::HTMLMediaElement::~HTMLMediaElement):
+ (WebCore::HTMLMediaElement::willMoveToNewOwnerDocument):
+ (WebCore::HTMLMediaElement::didMoveToNewOwnerDocument):
+
2011-12-15 Eric Carlson <[email protected]>
Text tracks should be treated differently according to their kind
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (102968 => 102969)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-12-15 19:18:54 UTC (rev 102968)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-12-15 19:28:14 UTC (rev 102969)
@@ -238,7 +238,6 @@
#endif
{
LOG(Media, "HTMLMediaElement::HTMLMediaElement");
- document->registerForDocumentActivationCallbacks(this);
document->registerForMediaVolumeCallbacks(this);
document->registerForPrivateBrowsingStateChangedCallbacks(this);
@@ -260,7 +259,6 @@
if (m_isWaitingUntilMediaCanStart)
document()->removeMediaCanStartListener(this);
setShouldDelayLoadEvent(false);
- document()->unregisterForDocumentActivationCallbacks(this);
document()->unregisterForMediaVolumeCallbacks(this);
document()->unregisterForPrivateBrowsingStateChangedCallbacks(this);
#if ENABLE(VIDEO_TRACK)
@@ -283,7 +281,6 @@
if (m_isWaitingUntilMediaCanStart)
document()->removeMediaCanStartListener(this);
setShouldDelayLoadEvent(false);
- document()->unregisterForDocumentActivationCallbacks(this);
document()->unregisterForMediaVolumeCallbacks(this);
removeElementFromDocumentMap(this, document());
HTMLElement::willMoveToNewOwnerDocument();
@@ -295,7 +292,6 @@
document()->addMediaCanStartListener(this);
if (m_readyState < HAVE_CURRENT_DATA)
setShouldDelayLoadEvent(true);
- document()->registerForDocumentActivationCallbacks(this);
document()->registerForMediaVolumeCallbacks(this);
addElementToDocumentMap(this, document());
HTMLElement::didMoveToNewOwnerDocument();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
