Title: [102977] trunk/Source/WebCore
- Revision
- 102977
- Author
- [email protected]
- Date
- 2011-12-15 13:07:14 -0800 (Thu, 15 Dec 2011)
Log Message
Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
https://bugs.webkit.org/show_bug.cgi?id=72013
Reviewed by Pavel Feldman.
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._messagesClicked):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.DatabaseTreeElement.prototype.onexpand):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (102976 => 102977)
--- trunk/Source/WebCore/ChangeLog 2011-12-15 20:46:29 UTC (rev 102976)
+++ trunk/Source/WebCore/ChangeLog 2011-12-15 21:07:14 UTC (rev 102977)
@@ -1,3 +1,16 @@
+2011-12-15 Vsevolod Vlasov <[email protected]>
+
+ Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes.
+ https://bugs.webkit.org/show_bug.cgi?id=72013
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/DatabaseQueryView.js:
+ (WebInspector.DatabaseQueryView):
+ (WebInspector.DatabaseQueryView.prototype._messagesClicked):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.DatabaseTreeElement.prototype.onexpand):
+
2011-12-15 Anders Carlsson <[email protected]>
Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define
Modified: trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js (102976 => 102977)
--- trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js 2011-12-15 20:46:29 UTC (rev 102976)
+++ trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js 2011-12-15 21:07:14 UTC (rev 102977)
@@ -36,7 +36,6 @@
this.element.addStyleClass("storage-view");
this.element.addStyleClass("query");
this.element.addStyleClass("monospace");
- this.element.tabIndex = 0;
this.element.addEventListener("selectstart", this._selectStart.bind(this), false);
this._promptElement = document.createElement("div");
@@ -47,6 +46,8 @@
this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), " ");
this.prompt.attach(this._promptElement);
+
+ this.element.addEventListener("click", this._messagesClicked.bind(this), true);
}
WebInspector.DatabaseQueryView.Events = {
@@ -54,22 +55,12 @@
}
WebInspector.DatabaseQueryView.prototype = {
- wasShown: function()
+ _messagesClicked: function()
{
- function moveBackIfOutside()
- {
- if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
- this.prompt.moveCaretToEndOfPrompt();
- }
-
- setTimeout(moveBackIfOutside.bind(this), 0);
+ if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
+ this.prompt.moveCaretToEndOfPrompt();
},
-
- afterShow: function()
- {
- WebInspector.setCurrentFocusElement(this._promptElement);
- },
-
+
completions: function(wordRange, force, completionsReadyCallback)
{
var prefix = wordRange.toString().toLowerCase();
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (102976 => 102977)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-12-15 20:46:29 UTC (rev 102976)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-12-15 21:07:14 UTC (rev 102977)
@@ -1436,14 +1436,12 @@
this._storagePanel.showDatabase(this._database);
},
- oncollapse: function()
+ onexpand: function()
{
- // Request a refresh after every collapse so the next
- // expand will have an updated table list.
- this.shouldRefreshChildren = true;
+ this._updateChildren();
},
- onpopulate: function()
+ _updateChildren: function()
{
this.removeChildren();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
