Title: [102994] trunk/Tools
Revision
102994
Author
[email protected]
Date
2011-12-15 16:18:35 -0800 (Thu, 15 Dec 2011)

Log Message

TestFailures: store the name of the buildbot results directory in a property
https://bugs.webkit.org/show_bug.cgi?id=74663

Reviewed by Adam Barth.

Store the name of the results directory as a property on Buildbot's
prototype. This allows subclasses of Buildbot to customize the results
directory.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
(Buildbot.prototype.resultsDirectoryURL):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js (102993 => 102994)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js	2011-12-16 00:02:59 UTC (rev 102993)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js	2011-12-16 00:18:35 UTC (rev 102994)
@@ -30,6 +30,7 @@
 
 Buildbot.prototype = {
     _builders: {},
+    _resultsDirectory: 'results/',
 
     buildURL: function(builderName, buildName) {
         return this.baseURL + 'builders/' + builderName + '/builds/' + buildName;
@@ -49,7 +50,7 @@
         }
 
         var self = this;
-        getResource(this.baseURL + 'results/', function(xhr) {
+        getResource(this.baseURL + this._resultsDirectory, function(xhr) {
             var root = document.createElement('html');
             root.innerHTML = xhr.responseText;
             var names = Array.prototype.map.call(root.querySelectorAll('td:first-child > a > b'), function(elem) {
@@ -69,7 +70,7 @@
     },
 
     resultsDirectoryURL: function(builderName, buildName) {
-        return this.baseURL + 'results/' + encodeURIComponent(builderName) + '/' + encodeURIComponent(buildName) + '/';
+        return this.baseURL + this._resultsDirectory + encodeURIComponent(builderName) + '/' + encodeURIComponent(buildName) + '/';
     },
 
     _buildersForNames: function(names) {

Modified: trunk/Tools/ChangeLog (102993 => 102994)


--- trunk/Tools/ChangeLog	2011-12-16 00:02:59 UTC (rev 102993)
+++ trunk/Tools/ChangeLog	2011-12-16 00:18:35 UTC (rev 102994)
@@ -1,3 +1,17 @@
+2011-12-15  Andy Estes  <[email protected]>
+
+        TestFailures: store the name of the buildbot results directory in a property
+        https://bugs.webkit.org/show_bug.cgi?id=74663
+
+        Reviewed by Adam Barth.
+        
+        Store the name of the results directory as a property on Buildbot's
+        prototype. This allows subclasses of Buildbot to customize the results
+        directory.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
+        (Buildbot.prototype.resultsDirectoryURL):
+
 2011-12-15  Tony Chang  <[email protected]>
 
         [chromium] pass --delete_unversioned_trees to gclient on the bots
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to