Title: [103003] trunk/Source/_javascript_Core
- Revision
- 103003
- Author
- [email protected]
- Date
- 2011-12-15 17:12:45 -0800 (Thu, 15 Dec 2011)
Log Message
Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
https://bugs.webkit.org/show_bug.cgi?id=74624
Patch by Andy Wingo <[email protected]> on 2011-12-15
Reviewed by Darin Adler.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Fix variables unused in
release mode.
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment): Fix
signed/unsigned comparison warning, with a cast.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (103002 => 103003)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-16 01:08:25 UTC (rev 103002)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-16 01:12:45 UTC (rev 103003)
@@ -1,5 +1,19 @@
2011-12-15 Andy Wingo <[email protected]>
+ Warnings fixes in Interpreter.cpp and PrivateExecute.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=74624
+
+ Reviewed by Darin Adler.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::privateExecute): Fix variables unused in
+ release mode.
+ * wtf/ParallelJobsGeneric.cpp:
+ (WTF::ParallelEnvironment::ParallelEnvironment): Fix
+ signed/unsigned comparison warning, with a cast.
+
+2011-12-15 Andy Wingo <[email protected]>
+
Use more macrology in JSC::Options
https://bugs.webkit.org/show_bug.cgi?id=72938
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (103002 => 103003)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-12-16 01:08:25 UTC (rev 103002)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-12-16 01:12:45 UTC (rev 103003)
@@ -2655,17 +2655,17 @@
ScopeChainNode* scopeChain = callFrame->scopeChain();
ScopeChainIterator iter = scopeChain->begin();
ScopeChainIterator end = scopeChain->end();
- ASSERT(iter != end);
+ ASSERT_UNUSED(end, iter != end);
ASSERT(codeBlock == callFrame->codeBlock());
bool checkTopLevel = codeBlock->codeType() == FunctionCode && codeBlock->needsFullScopeChain();
ASSERT(skip || !checkTopLevel);
- if (checkTopLevel && skip--) {
+ if (checkTopLevel && skip--) {
if (callFrame->r(codeBlock->activationRegister()).jsValue())
++iter;
}
while (skip--) {
++iter;
- ASSERT(iter != end);
+ ASSERT_UNUSED(end, iter != end);
}
ASSERT((*iter)->isVariableObject());
JSVariableObject* scope = static_cast<JSVariableObject*>(iter->get());
@@ -2686,16 +2686,16 @@
ScopeChainIterator iter = scopeChain->begin();
ScopeChainIterator end = scopeChain->end();
ASSERT(codeBlock == callFrame->codeBlock());
- ASSERT(iter != end);
+ ASSERT_UNUSED(end, iter != end);
bool checkTopLevel = codeBlock->codeType() == FunctionCode && codeBlock->needsFullScopeChain();
ASSERT(skip || !checkTopLevel);
- if (checkTopLevel && skip--) {
+ if (checkTopLevel && skip--) {
if (callFrame->r(codeBlock->activationRegister()).jsValue())
++iter;
}
while (skip--) {
++iter;
- ASSERT(iter != end);
+ ASSERT_UNUSED(end, iter != end);
}
ASSERT((*iter)->isVariableObject());
Modified: trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp (103002 => 103003)
--- trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp 2011-12-16 01:08:25 UTC (rev 103002)
+++ trunk/Source/_javascript_Core/wtf/ParallelJobsGeneric.cpp 2011-12-16 01:12:45 UTC (rev 103003)
@@ -66,7 +66,7 @@
int maxNumberOfNewThreads = requestedJobNumber - 1;
for (int i = 0; i < s_maxNumberOfParallelThreads && m_threads.size() < static_cast<unsigned>(maxNumberOfNewThreads); ++i) {
- if (s_threadPool->size() < i + 1)
+ if (s_threadPool->size() < static_cast<unsigned>(i) + 1U)
s_threadPool->append(ThreadPrivate::create());
if ((*s_threadPool)[i]->tryLockFor(this))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
