Title: [249653] trunk/Tools
- Revision
- 249653
- Author
- [email protected]
- Date
- 2019-09-09 11:56:47 -0700 (Mon, 09 Sep 2019)
Log Message
Remove all selection view animations before dumping results
https://bugs.webkit.org/show_bug.cgi?id=199241
Reviewed by Wenson Hsieh.
On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
historical tests that were written for Mac and expect Mac's lack of animations that we run on
iOS and are flaky. Let's try to remove all selection view animations before dumping results and
see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
API for a test to remove selection animations at any time during the run.
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::notifyDone):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (249652 => 249653)
--- trunk/Tools/ChangeLog 2019-09-09 18:29:12 UTC (rev 249652)
+++ trunk/Tools/ChangeLog 2019-09-09 18:56:47 UTC (rev 249653)
@@ -1,3 +1,19 @@
+2019-09-09 Daniel Bates <[email protected]>
+
+ Remove all selection view animations before dumping results
+ https://bugs.webkit.org/show_bug.cgi?id=199241
+
+ Reviewed by Wenson Hsieh.
+
+ On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
+ historical tests that were written for Mac and expect Mac's lack of animations that we run on
+ iOS and are flaky. Let's try to remove all selection view animations before dumping results and
+ see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
+ API for a test to remove selection animations at any time during the run.
+
+ * WebKitTestRunner/ios/TestControllerIOS.mm:
+ (WTR::TestController::notifyDone):
+
2019-09-09 Jonathan Bedard <[email protected]>
run-webkit-tests: Report results archive to results.webkit.org
Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (249652 => 249653)
--- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-09-09 18:29:12 UTC (rev 249652)
+++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm 2019-09-09 18:56:47 UTC (rev 249653)
@@ -82,6 +82,9 @@
void TestController::notifyDone()
{
+ UIView *contentView = [mainWebView()->platformView() valueForKeyPath:@"_currentContentView"];
+ UIView *selectionView = [contentView valueForKeyPath:@"interactionAssistant.selectionView"];
+ [selectionView _removeAllAnimations:YES];
}
void TestController::platformInitialize()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
