Title: [249691] branches/safari-608-branch/Source/WebKit
Revision
249691
Author
alanc...@apple.com
Date
2019-09-09 20:19:37 -0700 (Mon, 09 Sep 2019)

Log Message

Cherry-pick r249454. rdar://problem/55198071

    [macOS] Unable to open local file from favorites bar
    https://bugs.webkit.org/show_bug.cgi?id=201444

    Reviewed by Brent Fulgham.

    The sandbox extension handle should be created providing the pid of the receiving process.

    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (249690 => 249691)


--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-09-10 03:19:35 UTC (rev 249690)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-09-10 03:19:37 UTC (rev 249691)
@@ -1,5 +1,34 @@
 2019-09-09  Kocsen Chung  <kocsen_ch...@apple.com>
 
+        Cherry-pick r249454. rdar://problem/55198071
+
+    [macOS] Unable to open local file from favorites bar
+    https://bugs.webkit.org/show_bug.cgi?id=201444
+    
+    Reviewed by Brent Fulgham.
+    
+    The sandbox extension handle should be created providing the pid of the receiving process.
+    
+    * UIProcess/WebPageProxy.cpp:
+    (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-09-03  Per Arne Vollan  <pvol...@apple.com>
+
+            [macOS] Unable to open local file from favorites bar
+            https://bugs.webkit.org/show_bug.cgi?id=201444
+
+            Reviewed by Brent Fulgham.
+
+            The sandbox extension handle should be created providing the pid of the receiving process.
+
+            * UIProcess/WebPageProxy.cpp:
+            (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+
+2019-09-09  Kocsen Chung  <kocsen_ch...@apple.com>
+
         Cherry-pick r249444. rdar://problem/55093558
 
     Null deref under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]'s handler block

Modified: branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (249690 => 249691)


--- branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-09-10 03:19:35 UTC (rev 249690)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-09-10 03:19:37 UTC (rev 249691)
@@ -1053,6 +1053,12 @@
         if (process.hasAssumedReadAccessToURL(resourceDirectoryURL))
             return;
 
+#if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID)
+        if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) {
+            m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL);
+            return;
+        }
+#endif
         if (SandboxExtension::createHandle(resourceDirectoryURL.fileSystemPath(), SandboxExtension::Type::ReadOnly, sandboxExtensionHandle)) {
             m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL);
             return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to